Fix galactus stylesheets for CKEditor 5. #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelpittet
reviewed
Jan 12, 2023
joelpittet
reviewed
Jan 12, 2023
joelpittet
requested changes
Jan 12, 2023
joelpittet
approved these changes
Jan 13, 2023
|
@occupant This looks good to merge from my stand point, thoughts? |
|
@joelpittet Yup, that's good to go. I spent far longer than I care to admit not noticing that the ckeditor5-stylesheets key used a dash instead of an underscore! |
|
I think we were in the same boat on the underscore, I just happened to notice it in review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.