-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clf local options #57
Conversation
Add CSS, JS and IMG assets locally instead of refering to CDN (js still makes a single call to CDN js for search region / footer content -) Add new local library for CSS / JS Add new CDN library for CLF javascript Update CDN libraries to include a CDN version of the javascript Add Settings to load the new libraries Add defaults for install
Adds the same reset and print styles as the CLF Adds all 4 colour/width variants in clf.local.css Remove old local.css file Update library for local clf Update body classes added to apply new local theme options
@occupant The "Use Minimal CLF" doesn't work if local is chosen. Maybe we can hide and disable that option if they choose local? |
|
A big part of why they are broken is mostly because I overwrote the generic |
Right, the help text does note that it's just there for legacy purposes (to prevent existing settings from being lost), but hiding it altogther is a much better option. |
Right, this has been an ongoing issue (the name is just too generic and too likely to be used by other css). I'd prefer to change the markup to reference EDIT: or am I misunderstanding the issue? Just reread it and I'm not quite sure. Do you mind posting your container style overrides? |
Some of this I can deal with because I caused it and it's meant for expert level. So I think I'm game for merging with that class added back |
@occupant I'm on board with the |
+1 for changing to |
I was going to also correct "Use an external, minimal copy of the CLS [sp] css files." but I think that's going away, non? |
No description provided.