Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clf local options #57

Merged
merged 9 commits into from
Aug 29, 2023
Merged

Clf local options #57

merged 9 commits into from
Aug 29, 2023

Conversation

occupant
Copy link
Member

No description provided.

joelpittet and others added 7 commits August 26, 2020 14:14
Add CSS, JS and IMG assets locally instead of refering to CDN (js still makes a single call to CDN js for search region / footer content -)
Add new local library for CSS / JS
Add new CDN library for CLF javascript
Update CDN libraries to include a CDN version of the javascript
Add Settings to load the new libraries
Add defaults for install
Adds the same reset and print styles as the CLF
Adds all 4 colour/width variants in clf.local.css
Remove old local.css file
Update library for local clf
Update body classes added to apply new local theme options
@joelpittet
Copy link
Collaborator

@occupant The "Use Minimal CLF" doesn't work if local is chosen. Maybe we can hide and disable that option if they choose local?

@joelpittet
Copy link
Collaborator

Screen Shot 2021-07-02 at 17 07 50-fullpage
Screen Shot 2021-07-02 at 17 07 43-fullpage
@occupant Currently something's not quite right with local, uploading screenshots of the homepage

@joelpittet
Copy link
Collaborator

A big part of why they are broken is mostly because I overwrote the generic .container classes and now local is more specific...

@occupant
Copy link
Member Author

occupant commented Jul 3, 2021

@occupant The "Use Minimal CLF" doesn't work if local is chosen. Maybe we can hide and disable that option if they choose local?

Right, the help text does note that it's just there for legacy purposes (to prevent existing settings from being lost), but hiding it altogther is a much better option.

@occupant
Copy link
Member Author

occupant commented Jul 3, 2021

A big part of why they are broken is mostly because I overwrote the generic .container classes and now local is more specific...

Right, this has been an ongoing issue (the name is just too generic and too likely to be used by other css). I'd prefer to change the markup to reference clf-container and the CSS accordingly, but that would necessitate a change to the page.html.twig. That said, I think it's a good thing to move forward with. Thoughts on that?

EDIT: or am I misunderstanding the issue? Just reread it and I'm not quite sure. Do you mind posting your container style overrides?

@joelpittet
Copy link
Collaborator

Some of this I can deal with because I caused it and it's meant for expert level. So I think I'm game for merging with that class added back

@joelpittet
Copy link
Collaborator

@occupant I'm on board with the .clf-container change idea, and that it only adds it when local is chosen.

@darko-hrgovic
Copy link

darko-hrgovic commented Jul 6, 2021

+1 for changing to .clf-container

@darkodevubc
Copy link
Contributor

I was going to also correct "Use an external, minimal copy of the CLS [sp] css files." but I think that's going away, non?

@joelpittet joelpittet merged commit 0ef99df into develop Aug 29, 2023
@joelpittet joelpittet deleted the clf-local-options branch August 29, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants