Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug stuff left in #236

Open
partyblob opened this issue Dec 29, 2024 · 2 comments
Open

Debug stuff left in #236

partyblob opened this issue Dec 29, 2024 · 2 comments

Comments

@partyblob
Copy link

https://github.com/uNetworking/uSockets/blame/182b7e4fe7211f98682772be3df89c71dc4884fa/src/crypto/openssl.c#L539

Also whenever this part runs the server I am hosting becomes unreachable

@uNetworkingAB
Copy link
Contributor

Can you run it under addresssanitizer or remove that printf? Maybe the string passed is not 0-terminated

@partyblob
Copy link
Author

partyblob commented Dec 29, 2024

I am running this under uWebSockets.js, the string appears to be properly null-terminated, no crash or undefined behaviour occurs. After some looking it seems to be called by a .removeServerName()/.addServerName() pair. I can't tell if the cert file is being read properly as it's read by uSockets, but it's possible that if it failed to read or read the wrong value then SSL would fail, causing the server to become unreachable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants