Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck in "rendering geoJSON" #367

Open
mmd-osm opened this issue Mar 20, 2018 · 7 comments
Open

Stuck in "rendering geoJSON" #367

mmd-osm opened this issue Mar 20, 2018 · 7 comments
Labels

Comments

@mmd-osm
Copy link
Contributor

mmd-osm commented Mar 20, 2018

Some queries produce really bad data, triggering error messages like "Error: Invalid LatLng object: (NaN, NaN)" on the javascript console while rendering geoJSON. Unfortunately, overpass turbo gets stuck here forever. It would be better to see at least some of the data (and optionally reporting that there was some issue rendering the result).

Example:

[adiff:"2018-02-13T20:53:00.000Z","2018-02-13T20:54:00.000Z"];
way(561040198);
(._; >;);
out meta geom;
@tyrasd tyrasd added the bug label Mar 21, 2018
@tyrasd
Copy link
Owner

tyrasd commented Mar 21, 2018

I agree that overpass turbo shouldn't crash on invalid input. But isn't this primarily (?) a bug of the overpass api: drolbr/Overpass-API#463 (falsely returning a deleted way version as not-deleted)

@mmd-osm
Copy link
Contributor Author

mmd-osm commented Mar 21, 2018

isn't this primarily (?) a bug of the overpass api

Yes, exactly, that's what I meant with "Some queries produce really bad data"... :)

@gy-mate
Copy link

gy-mate commented Feb 13, 2024

I've just ran into this with the following query:

way(680443640) ->.searchArea;
nwr(area.searchArea);
out;

But it's still the same with the query mentioned in the issue description.

@mmd-osm
Copy link
Contributor Author

mmd-osm commented Feb 13, 2024

@gy-mate : I cannot reproduce the issue. On which Overpass instance are you running your query?

@gy-mate
Copy link

gy-mate commented Feb 13, 2024

@mmd-osm I'm using 2024-01-15/8db5c43 on www.overpass-turbo.eu with Safari 17.3.1. It worked for me once a few minutes ago, but it's not working, again:

Screenshot 2024-02-13 at 18 26 48

The following error appears in the console just when it starts rendering geoJSON:

[Error] TypeError: undefined is not an object (evaluating 'e.lat')
	project (urlParameters-2b23d0ae.js:16:14665)
	latLngToPoint (urlParameters-2b23d0ae.js:16:13266)
	(anonymous function) (urlParameters-2b23d0ae.js:290:38772)
	eachLayer (urlParameters-2b23d0ae.js:16:72072)
	_onZoomEnd (urlParameters-2b23d0ae.js:290:38126)
	onAdd (urlParameters-2b23d0ae.js:290:37906)
	_layerAdd (urlParameters-2b23d0ae.js:16:69562)
	whenReady (urlParameters-2b23d0ae.js:16:44489)
	addLayer (urlParameters-2b23d0ae.js:16:69844)
	addTo (urlParameters-2b23d0ae.js:16:68896)
	onAdd (urlParameters-2b23d0ae.js:290:37589)
	_layerAdd (urlParameters-2b23d0ae.js:16:69562)
	whenReady (urlParameters-2b23d0ae.js:16:44489)
	addLayer (urlParameters-2b23d0ae.js:16:69844)
	(anonymous function) (index-fbed9313.js:754:33253)
	(anonymous function) (urlParameters-2b23d0ae.js:308:4631)
	(anonymous function) (urlParameters-2b23d0ae.js:290:37466) 

@mmd-osm
Copy link
Contributor Author

mmd-osm commented Feb 13, 2024

Thank you, I could reproduce the issue for a few minutes only, but now it's working ok again.

Note that this issue was originally created for "Error: Invalid LatLng object: (NaN, NaN)". which causes a stuck UI, but likely for different reasons.

@gy-mate
Copy link

gy-mate commented Feb 13, 2024

Note that this issue was originally created for "Error: Invalid LatLng object: (NaN, NaN)". which causes a stuck UI, but likely for different reasons.

@mmd-osm Oh, thanks for the heads-up! I've opened a new issue for this one: #686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants