fix: routes from imported controllers via directory return 404 in 0.10.0

[dbrewer5]

Description

It seems that using the directory-based import as described in the documentation does not work after upgrading to v0.10.0. Falling back to directly registering each controller works as intended. This applies when setting both, controllers and middleware.

Minimal code-snippet showcasing the problem

import { createKoaServer } from 'routing-controllers'
import { join } from 'path'

const app = createKoaServer({
    controllers: [join(__dirname, '/controllers/*.*s')],
    middleware: [join(__dirname, '/middleware/*.*s')]
})

app.listen(3000) // all routes will return 404 and middleware will be ignored

Expected behavior

Should keep working as it did in v0.9.0.

Actual behavior

All routes associated with registered controllers return 404 and middleware is ignored.

[attilaorosz]

Does not found mean it returns 404 or the modules themselves are not found when starting the app?

[dbrewer5]

Does not found mean it returns 404 or the modules themselves are not found when starting the app?

All routes return 404. I've updated the issue to reflect that correctly.

[attilaorosz]

Could you please provide a bit more info? I cannot reproduce this locally.

[attilaorosz]

I'm tring with this snippet:

import {createKoaServer} from "routing-controllers";
import {join} from 'path';

const axios = require('axios');

const application = createKoaServer( {
    controllers: [join(__dirname, '/controllers/*.*s')],
    middlewares: []
});

application.listen(4200);

axios.get('http://localhost:4200/api/first').then((resp: any) => {
    console.log(resp);
});

[jcrka]

Are you on windows ?
May be this is the same ? #987

[Apperk274]

Still does not work on Windows after fix #994

[attilaorosz]

Have you tried locally? This is not released yet I guess.

[Apperk274]

Oh sorry, I thought it was in 0.10.1 release. My bad

[attilaorosz]

Should be released. Please close this issue if it works for you or add a comment if not.

[attilaorosz]

Closing as complete, please reopen if you find an issue.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.