Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check headers for all Scala versions #369

Closed
kubukoz opened this issue Sep 17, 2022 · 2 comments · Fixed by #542
Closed

Check headers for all Scala versions #369

kubukoz opened this issue Sep 17, 2022 · 2 comments · Fixed by #542
Labels
bug core

Comments

@kubukoz
Copy link
Member

kubukoz commented Sep 17, 2022

In project that have different source directories depending on the Scala version, it would be useful to have the header check run with +:

sbt +headerCheckAll.

Same goes for the prePR call to headerCreateAll.
@armanbilge
Copy link
Member

Thanks. The prePR command should be fixed, but the CI command is already running for every scala version in the matrix.

sbt-typelevel/.github/workflows/ci.yml

Line 90 in 5643503

run: sbt 'project ${{ matrix.project }}' '++${{ matrix.scala }}' headerCheckAll scalafmtCheckAll 'project /' scalafmtSbtCheck

@kubukoz
Copy link
Member Author

kubukoz commented Sep 17, 2022

ah, I see. I only hit it in prePR so that makes sense.

@armanbilge armanbilge linked a pull request Jun 19, 2023 that will close this issue
Better prePR command #542
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Better prePR command typelevel/sbt-typelevel
2 participants
@kubukoz @armanbilge