Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root / doc passes but unidoc / Scalaunidoc / doc and root / packageDoc fail #214

Closed
armanbilge opened this issue Mar 16, 2022 · 2 comments · Fixed by #216
Closed

root / doc passes but unidoc / Scalaunidoc / doc and root / packageDoc fail #214

armanbilge opened this issue Mar 16, 2022 · 2 comments · Fixed by #216
Labels
Milestone

Comments

@armanbilge
Copy link
Member

When using the TypelevelUnidocPlugin this can cause CI to pass in PRs but publishing to fail.

With many apologies to @TimWSpence who unwittingly uncovered this one in cats-stm 😆

In the cats-stm case, it comes down to the duplicate JVM/JS docs problem. Would be nice to fix that automatically as well.

@armanbilge armanbilge added the bug label Mar 16, 2022
@armanbilge armanbilge added this to the v0.4.7 milestone Mar 16, 2022
@TimWSpence
Copy link
Member

😂 I had noticed that the docs hadn't been published but thought I maybe hadn't pubished a new version since I fixed the build setup and didn't have time to check.

@armanbilge
Copy link
Member Author

@TimWSpence yeah, you need to add something like:

ScalaUnidoc / unidoc / unidocProjectFilter := inAnyProject -- inProjects(root.js.aggregate: _*)

CI for the PR should have picked this up, but, you know, bugs 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants