Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should we handle transitive updates? #113

Closed
armanbilge opened this issue Jan 28, 2022 · 2 comments
Closed

How should we handle transitive updates? #113

armanbilge opened this issue Jan 28, 2022 · 2 comments
Labels

Comments

@armanbilge
Copy link
Member

I'd like be mindful of how we provide transitive updates to our downstreams. I suppose this is a versioning question?

E.g. consider:

which didn't pass CI in typelevel/cats#4120.

@rossabaker
Copy link
Member

As a first cut, I like to mirror the dependencies:

  • patch dep -> patch bump
  • minor dep -> minor bump
  • major dep -> major bump

Now, some libraries have different ideas of semver, and we might need to "correct" them.

The minor dep (someone else's new features) could just be a patch dep for us... but now we're cornered if our clients can't adopt the minorly bumped dep.

At the end of the day, it's about expressing the right amount of fear and trepidation downstream, but going at least as hard as our most frightened and trepidacious dependency did is a good start.

@armanbilge
Copy link
Member Author

armanbilge commented Jan 28, 2022

Works for me! (closing as resolved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants