Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Unidoc with TypelevelSitePlugin #108

Closed
armanbilge opened this issue Jan 28, 2022 · 6 comments · Fixed by #119
Closed

Integrate Unidoc with TypelevelSitePlugin #108

armanbilge opened this issue Jan 28, 2022 · 6 comments · Fixed by #119
Milestone

Comments

@armanbilge
Copy link
Member

So far I've been cheating with javadoc.io URLs but that only works well for single-module projects. Laika supports API docs, so I think that should be easy. The hard part is that although my preference is for sites that are updated on every push, scaladocs should definitely only be updated on tags.

@armanbilge armanbilge added this to the v0.5.0 milestone Jan 28, 2022
@rossabaker
Copy link
Member

Why should scaladocs only be updated on tags? http4s published on push for years. (Counterpoint: this is why the repo is enormous on first clone.)

@armanbilge
Copy link
Member Author

armanbilge commented Jan 28, 2022

It's because as soon as you add a new method that hasn't been released, the scaladocs are misleading (this happened recently in Cats Effect).

Edit: oh, I guess scaladocs go at a version-specific URL 🤔

Edit 2: e.g. CE just puts them at 3.x:
https://typelevel.org/cats-effect/api/3.x/cats/effect/index.html

@rossabaker
Copy link
Member

I would think it's the same basic tradeoffs as the mdocs: you don't want to document unreleased features, but you might not want to do a patch release to fix a typo in the {mdocs, scaladocs}.

@armanbilge
Copy link
Member Author

armanbilge commented Jan 28, 2022

That's fair. The difference in my eyes is that scaladocs change in ordinary development but mdocs change more deliberately, when we actually write docs 😅

The real solution is what CE is doing now, which is publishing docs from every push to a daily from the 3.3.x branch which is strictly forwards/backwards compatible.

@armanbilge
Copy link
Member Author

To give a concrete example: the ember h2 stuff would already be showing up in http4s scaladocs. But if somebody adds some mdocumentation for it, we can easily hold that PR until the right time to merge.

@rossabaker
Copy link
Member

Okay, that's a fair distinction.

@armanbilge armanbilge linked a pull request Jan 29, 2022 that will close this issue
@armanbilge armanbilge modified the milestones: v0.5.0, v0.4.5 Feb 10, 2022
@armanbilge armanbilge linked a pull request Mar 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants