From cf071c9fe9124b8e9d187be5de0f2121587088fe Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 17:32:47 +0000 Subject: [PATCH 1/9] Added test --- tests/src/test/scala/cats/tests/ShowSuite.scala | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/src/test/scala/cats/tests/ShowSuite.scala b/tests/src/test/scala/cats/tests/ShowSuite.scala index 99d1997ba0..824d55e269 100644 --- a/tests/src/test/scala/cats/tests/ShowSuite.scala +++ b/tests/src/test/scala/cats/tests/ShowSuite.scala @@ -1,11 +1,15 @@ package cats package tests -import cats.Contravariant +import java.util.concurrent.TimeUnit + +import cats.Show.ContravariantShow import cats.laws.discipline.arbitrary._ import cats.laws.discipline.{ContravariantTests, SerializableTests} import cats.laws.discipline.eq._ +import scala.concurrent.duration.FiniteDuration + class ShowSuite extends CatsSuite { checkAll("Contravariant[Show]", ContravariantTests[Show].contravariant[Int, Int, Int]) checkAll("Contravariant[Show]", SerializableTests.serializable(Contravariant[Show])) @@ -34,4 +38,12 @@ class ShowSuite extends CatsSuite { assertResult("Good morning")(show"Good $tod") } + + test("contravariant show is not ambiguous when both FiniteDuration's and Duration's instances are in scope") { + implicitly[ContravariantShow[FiniteDuration]] + } + + test("show interpolation works when both FiniteDuration's and Duration's instances are in scope") { + show"instance resolution is not ambiguous for ${FiniteDuration(3L, TimeUnit.SECONDS)}" + } } From dcf0dd025f55642a38f2b2248217a0ec6d995ca9 Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 17:49:39 +0000 Subject: [PATCH 2/9] Fixed ambiguous implicits for FiniteDuration --- core/src/main/scala/cats/implicits.scala | 1 + core/src/main/scala/cats/instances/all.scala | 2 ++ .../main/scala/cats/instances/duration.scala | 21 +++++++++++++++++-- .../scala/cats/instances/finiteDuration.scala | 5 +++-- .../main/scala/cats/instances/package.scala | 4 ++-- 5 files changed, 27 insertions(+), 6 deletions(-) diff --git a/core/src/main/scala/cats/implicits.scala b/core/src/main/scala/cats/implicits.scala index 1267851ae6..6094afa1b9 100644 --- a/core/src/main/scala/cats/implicits.scala +++ b/core/src/main/scala/cats/implicits.scala @@ -11,3 +11,4 @@ object implicits with instances.AllInstancesBinCompat0 with instances.AllInstancesBinCompat1 with instances.AllInstancesBinCompat2 + with instances.AllInstancesBinCompat3 diff --git a/core/src/main/scala/cats/instances/all.scala b/core/src/main/scala/cats/instances/all.scala index 3cc7339d9d..ac39656cd0 100644 --- a/core/src/main/scala/cats/instances/all.scala +++ b/core/src/main/scala/cats/instances/all.scala @@ -44,3 +44,5 @@ trait AllInstancesBinCompat1 with SortedMapInstancesBinCompat0 trait AllInstancesBinCompat2 extends DurationInstances with FiniteDurationInstances + +trait AllInstancesBinCompat3 extends CoreDurationInstances diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index 2cc6f1b940..85c784fbd8 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -1,9 +1,26 @@ package cats package instances -import scala.concurrent.duration.Duration +import scala.concurrent.duration.{Duration, FiniteDuration} trait DurationInstances extends cats.kernel.instances.DurationInstances { - implicit val catsStdShowForDuration: Show[Duration] = + + val catsStdShowForDuration: Show[Duration] = + CoreDurationInstances().catsStdShowForDurationUnambiguous +} + +private[instances] trait CoreDurationInstances extends CoreDurationInstances0 + +private[instances] sealed trait CoreDurationInstances0 extends CoreDurationInstances1 { + implicit final val catsStdShowForFiniteDurationUnambiguous: Show[FiniteDuration] = + Show.fromToString[FiniteDuration] +} + +private[instances] sealed trait CoreDurationInstances1 { + implicit final val catsStdShowForDurationUnambiguous: Show[Duration] = Show.fromToString[Duration] } + +private[instances] object CoreDurationInstances { + final def apply(): CoreDurationInstances = new CoreDurationInstances {} +} diff --git a/core/src/main/scala/cats/instances/finiteDuration.scala b/core/src/main/scala/cats/instances/finiteDuration.scala index 182b7d9905..9170e3090f 100644 --- a/core/src/main/scala/cats/instances/finiteDuration.scala +++ b/core/src/main/scala/cats/instances/finiteDuration.scala @@ -4,6 +4,7 @@ package instances import scala.concurrent.duration.FiniteDuration trait FiniteDurationInstances extends cats.kernel.instances.FiniteDurationInstances { - implicit val catsStdShowForFiniteDuration: Show[FiniteDuration] = - Show.fromToString[FiniteDuration] + + val catsStdShowForFiniteDuration: Show[FiniteDuration] = + CoreDurationInstances().catsStdShowForFiniteDurationUnambiguous } diff --git a/core/src/main/scala/cats/instances/package.scala b/core/src/main/scala/cats/instances/package.scala index e32d519d53..dc4a0cacbc 100644 --- a/core/src/main/scala/cats/instances/package.scala +++ b/core/src/main/scala/cats/instances/package.scala @@ -9,12 +9,12 @@ package object instances { object byte extends ByteInstances object char extends CharInstances object double extends DoubleInstances - object duration extends DurationInstances + object duration extends CoreDurationInstances with DurationInstances object either extends EitherInstances object eq extends EqInstances object equiv extends EquivInstances object float extends FloatInstances - object finiteDuration extends FiniteDurationInstances + object finiteDuration extends CoreDurationInstances with FiniteDurationInstances object function extends FunctionInstances with FunctionInstancesBinCompat0 object future extends FutureInstances object int extends IntInstances From ef4b0c68122d566a104f1b83285c3c9f31f56d56 Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 17:50:06 +0000 Subject: [PATCH 3/9] Fixed tests --- testkit/src/main/scala/cats/tests/CatsSuite.scala | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testkit/src/main/scala/cats/tests/CatsSuite.scala b/testkit/src/main/scala/cats/tests/CatsSuite.scala index 6f881244a1..61418511e5 100644 --- a/testkit/src/main/scala/cats/tests/CatsSuite.scala +++ b/testkit/src/main/scala/cats/tests/CatsSuite.scala @@ -3,7 +3,7 @@ package tests import catalysts.Platform -import cats.instances.{AllInstances, AllInstancesBinCompat0, AllInstancesBinCompat1, AllInstancesBinCompat2} +import cats.instances.{AllInstances, AllInstancesBinCompat0, AllInstancesBinCompat1, AllInstancesBinCompat2, AllInstancesBinCompat3} import cats.syntax.{ AllSyntax, AllSyntaxBinCompat0, @@ -47,6 +47,7 @@ trait CatsSuite with AllInstancesBinCompat0 with AllInstancesBinCompat1 with AllInstancesBinCompat2 + with AllInstancesBinCompat3 with AllSyntax with AllSyntaxBinCompat0 with AllSyntaxBinCompat1 From b0b18e4fb4d26d3c810a0e0308d594d7993af81c Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 18:12:26 +0000 Subject: [PATCH 4/9] Refactoring to reduce allocation on direct use --- core/src/main/scala/cats/instances/duration.scala | 4 ++-- core/src/main/scala/cats/instances/finiteDuration.scala | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index 85c784fbd8..dc83db1ace 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -6,7 +6,7 @@ import scala.concurrent.duration.{Duration, FiniteDuration} trait DurationInstances extends cats.kernel.instances.DurationInstances { val catsStdShowForDuration: Show[Duration] = - CoreDurationInstances().catsStdShowForDurationUnambiguous + CoreDurationInstances.materialise.catsStdShowForDurationUnambiguous } private[instances] trait CoreDurationInstances extends CoreDurationInstances0 @@ -22,5 +22,5 @@ private[instances] sealed trait CoreDurationInstances1 { } private[instances] object CoreDurationInstances { - final def apply(): CoreDurationInstances = new CoreDurationInstances {} + final val materialise: CoreDurationInstances = new CoreDurationInstances {} } diff --git a/core/src/main/scala/cats/instances/finiteDuration.scala b/core/src/main/scala/cats/instances/finiteDuration.scala index 9170e3090f..b16e6cf699 100644 --- a/core/src/main/scala/cats/instances/finiteDuration.scala +++ b/core/src/main/scala/cats/instances/finiteDuration.scala @@ -6,5 +6,5 @@ import scala.concurrent.duration.FiniteDuration trait FiniteDurationInstances extends cats.kernel.instances.FiniteDurationInstances { val catsStdShowForFiniteDuration: Show[FiniteDuration] = - CoreDurationInstances().catsStdShowForFiniteDurationUnambiguous + CoreDurationInstances.materialise.catsStdShowForFiniteDurationUnambiguous } From b6f3a3ee87e45dc03c3d9dd9afac92a1f29e58cc Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 18:18:20 +0000 Subject: [PATCH 5/9] Pre PR --- core/src/main/scala/cats/instances/duration.scala | 4 ++-- testkit/src/main/scala/cats/tests/CatsSuite.scala | 8 +++++++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index dc83db1ace..60257f140e 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -11,12 +11,12 @@ trait DurationInstances extends cats.kernel.instances.DurationInstances { private[instances] trait CoreDurationInstances extends CoreDurationInstances0 -private[instances] sealed trait CoreDurationInstances0 extends CoreDurationInstances1 { +sealed private[instances] trait CoreDurationInstances0 extends CoreDurationInstances1 { implicit final val catsStdShowForFiniteDurationUnambiguous: Show[FiniteDuration] = Show.fromToString[FiniteDuration] } -private[instances] sealed trait CoreDurationInstances1 { +sealed private[instances] trait CoreDurationInstances1 { implicit final val catsStdShowForDurationUnambiguous: Show[Duration] = Show.fromToString[Duration] } diff --git a/testkit/src/main/scala/cats/tests/CatsSuite.scala b/testkit/src/main/scala/cats/tests/CatsSuite.scala index 61418511e5..e4da414b36 100644 --- a/testkit/src/main/scala/cats/tests/CatsSuite.scala +++ b/testkit/src/main/scala/cats/tests/CatsSuite.scala @@ -3,7 +3,13 @@ package tests import catalysts.Platform -import cats.instances.{AllInstances, AllInstancesBinCompat0, AllInstancesBinCompat1, AllInstancesBinCompat2, AllInstancesBinCompat3} +import cats.instances.{ + AllInstances, + AllInstancesBinCompat0, + AllInstancesBinCompat1, + AllInstancesBinCompat2, + AllInstancesBinCompat3 +} import cats.syntax.{ AllSyntax, AllSyntaxBinCompat0, From baed41ba71a4e322bc19e83bdc85633bc9109492 Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Sun, 16 Dec 2018 19:56:16 +0000 Subject: [PATCH 6/9] Test case --- tests/src/test/scala/cats/tests/ShowSuite.scala | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/src/test/scala/cats/tests/ShowSuite.scala b/tests/src/test/scala/cats/tests/ShowSuite.scala index 824d55e269..b12d1c826b 100644 --- a/tests/src/test/scala/cats/tests/ShowSuite.scala +++ b/tests/src/test/scala/cats/tests/ShowSuite.scala @@ -8,7 +8,7 @@ import cats.laws.discipline.arbitrary._ import cats.laws.discipline.{ContravariantTests, SerializableTests} import cats.laws.discipline.eq._ -import scala.concurrent.duration.FiniteDuration +import scala.concurrent.duration.{Duration, FiniteDuration} class ShowSuite extends CatsSuite { checkAll("Contravariant[Show]", ContravariantTests[Show].contravariant[Int, Int, Int]) @@ -41,9 +41,11 @@ class ShowSuite extends CatsSuite { test("contravariant show is not ambiguous when both FiniteDuration's and Duration's instances are in scope") { implicitly[ContravariantShow[FiniteDuration]] + implicitly[ContravariantShow[Duration]] } test("show interpolation works when both FiniteDuration's and Duration's instances are in scope") { show"instance resolution is not ambiguous for ${FiniteDuration(3L, TimeUnit.SECONDS)}" + show"instance resolution is not ambiguous for ${Duration(3L, TimeUnit.SECONDS)}" } } From 0dcd0298291bbc57c847f3ba2dc9dda5d4065d80 Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Thu, 20 Dec 2018 19:16:12 +0100 Subject: [PATCH 7/9] Mitigated existing problematic use case --- core/src/main/scala/cats/instances/all.scala | 2 +- .../main/scala/cats/instances/duration.scala | 13 +++++----- .../scala/cats/instances/finiteDuration.scala | 3 ++- .../main/scala/cats/instances/package.scala | 2 +- .../src/test/scala/cats/tests/ShowSuite.scala | 26 +++++++++++++++++++ 5 files changed, 37 insertions(+), 9 deletions(-) diff --git a/core/src/main/scala/cats/instances/all.scala b/core/src/main/scala/cats/instances/all.scala index ac39656cd0..b46054f9d2 100644 --- a/core/src/main/scala/cats/instances/all.scala +++ b/core/src/main/scala/cats/instances/all.scala @@ -45,4 +45,4 @@ trait AllInstancesBinCompat1 trait AllInstancesBinCompat2 extends DurationInstances with FiniteDurationInstances -trait AllInstancesBinCompat3 extends CoreDurationInstances +trait AllInstancesBinCompat3 extends AllCoreDurationInstances diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index 60257f140e..07d0948f8b 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -5,22 +5,23 @@ import scala.concurrent.duration.{Duration, FiniteDuration} trait DurationInstances extends cats.kernel.instances.DurationInstances { + @deprecated("Left to keep binary compatibility. Use CoreDurationInstances.catsStdShowForDurationUnambiguous instead.", "1.5.0") val catsStdShowForDuration: Show[Duration] = - CoreDurationInstances.materialise.catsStdShowForDurationUnambiguous + AllCoreDurationInstances.materialise.catsStdShowForDurationUnambiguous } -private[instances] trait CoreDurationInstances extends CoreDurationInstances0 +private[instances] trait AllCoreDurationInstances extends CoreFiniteDurationInstances -sealed private[instances] trait CoreDurationInstances0 extends CoreDurationInstances1 { +private[instances] trait CoreFiniteDurationInstances extends CoreDurationInstances { implicit final val catsStdShowForFiniteDurationUnambiguous: Show[FiniteDuration] = Show.fromToString[FiniteDuration] } -sealed private[instances] trait CoreDurationInstances1 { +private[instances] trait CoreDurationInstances { implicit final val catsStdShowForDurationUnambiguous: Show[Duration] = Show.fromToString[Duration] } -private[instances] object CoreDurationInstances { - final val materialise: CoreDurationInstances = new CoreDurationInstances {} +private[instances] object AllCoreDurationInstances { + final val materialise: AllCoreDurationInstances = new AllCoreDurationInstances {} } diff --git a/core/src/main/scala/cats/instances/finiteDuration.scala b/core/src/main/scala/cats/instances/finiteDuration.scala index b16e6cf699..de082333c6 100644 --- a/core/src/main/scala/cats/instances/finiteDuration.scala +++ b/core/src/main/scala/cats/instances/finiteDuration.scala @@ -5,6 +5,7 @@ import scala.concurrent.duration.FiniteDuration trait FiniteDurationInstances extends cats.kernel.instances.FiniteDurationInstances { + @deprecated("Left to keep binary compatibility. Use CoreFiniteDurationInstances.catsStdShowForFiniteDurationUnambiguous instead.", "1.5.0") val catsStdShowForFiniteDuration: Show[FiniteDuration] = - CoreDurationInstances.materialise.catsStdShowForFiniteDurationUnambiguous + AllCoreDurationInstances.materialise.catsStdShowForFiniteDurationUnambiguous } diff --git a/core/src/main/scala/cats/instances/package.scala b/core/src/main/scala/cats/instances/package.scala index dc4a0cacbc..60801f5e34 100644 --- a/core/src/main/scala/cats/instances/package.scala +++ b/core/src/main/scala/cats/instances/package.scala @@ -14,7 +14,7 @@ package object instances { object eq extends EqInstances object equiv extends EquivInstances object float extends FloatInstances - object finiteDuration extends CoreDurationInstances with FiniteDurationInstances + object finiteDuration extends CoreFiniteDurationInstances with FiniteDurationInstances object function extends FunctionInstances with FunctionInstancesBinCompat0 object future extends FutureInstances object int extends IntInstances diff --git a/tests/src/test/scala/cats/tests/ShowSuite.scala b/tests/src/test/scala/cats/tests/ShowSuite.scala index b12d1c826b..2bd3865433 100644 --- a/tests/src/test/scala/cats/tests/ShowSuite.scala +++ b/tests/src/test/scala/cats/tests/ShowSuite.scala @@ -7,6 +7,7 @@ import cats.Show.ContravariantShow import cats.laws.discipline.arbitrary._ import cats.laws.discipline.{ContravariantTests, SerializableTests} import cats.laws.discipline.eq._ +import org.scalatest.FunSuite import scala.concurrent.duration.{Duration, FiniteDuration} @@ -49,3 +50,28 @@ class ShowSuite extends CatsSuite { show"instance resolution is not ambiguous for ${Duration(3L, TimeUnit.SECONDS)}" } } + +final class ShowSuite2 extends FunSuite { + + test("contravariant show for FiniteDuration can be inferred when importing both duration's and finiteDuration's instances") { + + import cats.instances.duration._ + import cats.instances.finiteDuration._ + + implicitly[Order[Duration]] + implicitly[Order[FiniteDuration]] + + implicitly[ContravariantShow[FiniteDuration]] + } + + test("all the Duration's and FiniteDuration's instances can be correctly inferred when importing implicits") { + + import cats.implicits._ + + implicitly[Order[Duration]] + implicitly[Order[FiniteDuration]] + + implicitly[ContravariantShow[Duration]] + implicitly[ContravariantShow[FiniteDuration]] + } +} From 708ee5cecff5195e2c80ac50118120723b1c24df Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Thu, 20 Dec 2018 19:47:28 +0100 Subject: [PATCH 8/9] prePR --- core/src/main/scala/cats/instances/duration.scala | 3 ++- core/src/main/scala/cats/instances/finiteDuration.scala | 5 ++++- tests/src/test/scala/cats/tests/ShowSuite.scala | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index 07d0948f8b..9c8a888350 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -5,7 +5,8 @@ import scala.concurrent.duration.{Duration, FiniteDuration} trait DurationInstances extends cats.kernel.instances.DurationInstances { - @deprecated("Left to keep binary compatibility. Use CoreDurationInstances.catsStdShowForDurationUnambiguous instead.", "1.5.0") + @deprecated("Left to keep binary compatibility. Use CoreDurationInstances.catsStdShowForDurationUnambiguous instead.", + "1.5.0") val catsStdShowForDuration: Show[Duration] = AllCoreDurationInstances.materialise.catsStdShowForDurationUnambiguous } diff --git a/core/src/main/scala/cats/instances/finiteDuration.scala b/core/src/main/scala/cats/instances/finiteDuration.scala index de082333c6..677fe2c63e 100644 --- a/core/src/main/scala/cats/instances/finiteDuration.scala +++ b/core/src/main/scala/cats/instances/finiteDuration.scala @@ -5,7 +5,10 @@ import scala.concurrent.duration.FiniteDuration trait FiniteDurationInstances extends cats.kernel.instances.FiniteDurationInstances { - @deprecated("Left to keep binary compatibility. Use CoreFiniteDurationInstances.catsStdShowForFiniteDurationUnambiguous instead.", "1.5.0") + @deprecated( + "Left to keep binary compatibility. Use CoreFiniteDurationInstances.catsStdShowForFiniteDurationUnambiguous instead.", + "1.5.0" + ) val catsStdShowForFiniteDuration: Show[FiniteDuration] = AllCoreDurationInstances.materialise.catsStdShowForFiniteDurationUnambiguous } diff --git a/tests/src/test/scala/cats/tests/ShowSuite.scala b/tests/src/test/scala/cats/tests/ShowSuite.scala index 2bd3865433..0f70850121 100644 --- a/tests/src/test/scala/cats/tests/ShowSuite.scala +++ b/tests/src/test/scala/cats/tests/ShowSuite.scala @@ -53,7 +53,9 @@ class ShowSuite extends CatsSuite { final class ShowSuite2 extends FunSuite { - test("contravariant show for FiniteDuration can be inferred when importing both duration's and finiteDuration's instances") { + test( + "contravariant show for FiniteDuration can be inferred when importing both duration's and finiteDuration's instances" + ) { import cats.instances.duration._ import cats.instances.finiteDuration._ From 294b2e8e371fe1066bacf4572eebdb9d56458db7 Mon Sep 17 00:00:00 2001 From: Filippo Mariotti Date: Tue, 8 Jan 2019 22:08:15 +0100 Subject: [PATCH 9/9] Removed unneeded method --- core/src/main/scala/cats/instances/duration.scala | 6 ++---- core/src/main/scala/cats/instances/finiteDuration.scala | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/core/src/main/scala/cats/instances/duration.scala b/core/src/main/scala/cats/instances/duration.scala index 9c8a888350..8e0385390f 100644 --- a/core/src/main/scala/cats/instances/duration.scala +++ b/core/src/main/scala/cats/instances/duration.scala @@ -8,7 +8,7 @@ trait DurationInstances extends cats.kernel.instances.DurationInstances { @deprecated("Left to keep binary compatibility. Use CoreDurationInstances.catsStdShowForDurationUnambiguous instead.", "1.5.0") val catsStdShowForDuration: Show[Duration] = - AllCoreDurationInstances.materialise.catsStdShowForDurationUnambiguous + AllCoreDurationInstances.catsStdShowForDurationUnambiguous } private[instances] trait AllCoreDurationInstances extends CoreFiniteDurationInstances @@ -23,6 +23,4 @@ private[instances] trait CoreDurationInstances { Show.fromToString[Duration] } -private[instances] object AllCoreDurationInstances { - final val materialise: AllCoreDurationInstances = new AllCoreDurationInstances {} -} +private[instances] object AllCoreDurationInstances extends AllCoreDurationInstances diff --git a/core/src/main/scala/cats/instances/finiteDuration.scala b/core/src/main/scala/cats/instances/finiteDuration.scala index 677fe2c63e..22077abaeb 100644 --- a/core/src/main/scala/cats/instances/finiteDuration.scala +++ b/core/src/main/scala/cats/instances/finiteDuration.scala @@ -10,5 +10,5 @@ trait FiniteDurationInstances extends cats.kernel.instances.FiniteDurationInstan "1.5.0" ) val catsStdShowForFiniteDuration: Show[FiniteDuration] = - AllCoreDurationInstances.materialise.catsStdShowForFiniteDurationUnambiguous + AllCoreDurationInstances.catsStdShowForFiniteDurationUnambiguous }