From 1298c1347fab597fd45fa197ff70eb55b250a473 Mon Sep 17 00:00:00 2001 From: Marti Raudsepp Date: Tue, 27 Sep 2022 19:27:32 +0300 Subject: [PATCH] Disallow passing bytes for field verbose_name `verbose_name` is intended to be a human-readable string, not binary. --- django-stubs/contrib/gis/db/models/fields.pyi | 4 ++-- django-stubs/db/models/fields/__init__.pyi | 2 +- django-stubs/db/models/fields/related.pyi | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/django-stubs/contrib/gis/db/models/fields.pyi b/django-stubs/contrib/gis/db/models/fields.pyi index 2927b82b3..5b60ad802 100644 --- a/django-stubs/contrib/gis/db/models/fields.pyi +++ b/django-stubs/contrib/gis/db/models/fields.pyi @@ -20,7 +20,7 @@ def get_srid_info(srid: int, connection: Any) -> SRIDCacheEntry: ... class BaseSpatialField(Field[_ST, _GT]): def __init__( self, - verbose_name: Optional[Union[_StrOrPromise, bytes]] = ..., + verbose_name: Optional[_StrOrPromise] = ..., srid: int = ..., spatial_index: bool = ..., *, @@ -66,7 +66,7 @@ class GeometryField(BaseSpatialField): geography: Any = ... def __init__( self, - verbose_name: Optional[Union[_StrOrPromise, bytes]] = ..., + verbose_name: Optional[_StrOrPromise] = ..., dim: int = ..., geography: bool = ..., *, diff --git a/django-stubs/db/models/fields/__init__.pyi b/django-stubs/db/models/fields/__init__.pyi index 283a4d476..c73577ea8 100644 --- a/django-stubs/db/models/fields/__init__.pyi +++ b/django-stubs/db/models/fields/__init__.pyi @@ -429,7 +429,7 @@ class GenericIPAddressField(Field[_ST, _GT]): protocol: str = ... def __init__( self, - verbose_name: Optional[Any] = ..., + verbose_name: Optional[_StrOrPromise] = ..., name: Optional[Any] = ..., protocol: str = ..., unpack_ipv4: bool = ..., diff --git a/django-stubs/db/models/fields/related.pyi b/django-stubs/db/models/fields/related.pyi index d104cbcdc..3d872721c 100644 --- a/django-stubs/db/models/fields/related.pyi +++ b/django-stubs/db/models/fields/related.pyi @@ -121,7 +121,7 @@ class ForeignKey(ForeignObject[_ST, _GT]): to_field: Optional[str] = ..., db_constraint: bool = ..., *, - verbose_name: Optional[Union[_StrOrPromise, bytes]] = ..., + verbose_name: Optional[_StrOrPromise] = ..., name: Optional[str] = ..., primary_key: bool = ..., max_length: Optional[int] = ..., @@ -170,7 +170,7 @@ class OneToOneField(ForeignKey[_ST, _GT]): limit_choices_to: Optional[_AllLimitChoicesTo] = ..., parent_link: bool = ..., db_constraint: bool = ..., - verbose_name: Optional[Union[_StrOrPromise, bytes]] = ..., + verbose_name: Optional[_StrOrPromise] = ..., name: Optional[str] = ..., primary_key: bool = ..., max_length: Optional[int] = ..., @@ -230,7 +230,7 @@ class ManyToManyField(RelatedField[_ST, _GT]): db_table: Optional[str] = ..., swappable: bool = ..., *, - verbose_name: Optional[Union[_StrOrPromise, bytes]] = ..., + verbose_name: Optional[_StrOrPromise] = ..., name: Optional[str] = ..., primary_key: bool = ..., max_length: Optional[int] = ...,