-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account for breeding time reduction from "Philanthropist" #65
Comments
@tonyctalope What behavior are you seeing, specifically? What version of Pal Calc are you using? For me Philanthropist appears in the list of available passives, it's recognized by the Save Inspector, and solving for a pal with Philanthropist works just fine (Though I needed to go through a few different saves to find one which had pals with that passive) Are you sure your save file has pals with the Philanthropist passive? Does it show up in the Save Inspector? (Click the "Inspect" button when your save is selected) |
I was referring to the Philanthropist trait's bonus of +100% breed speed. It doesn’t seem to be factored into the breed speed calculations in Pal Calc ? |
@tonyctalope Ah I see, I thought you meant it wasn't being recognized as a passive, I wasn't even aware of that effect I agree this should be taken into account, do you know how the passive stacks? E.g. what's the breeding speed if 1 parent has it vs. both parents? |
I currently don't know, but I'll do some tests (it doesn’t look complicated) and let you know ASAP. |
I just tested a 25% breed:
For 100%, this translates to:
I also have this video that supports my tests: https://www.youtube.com/watch?v=39l5rO_NxPs |
I'll plan to address this in v1.10.0, along with IV solving |
Note: In addition to affecting breeding times for children, the solver should also consider children which inherit the Philanthropist passive, even if it's not intended for the final pal |
Will leave this out for now - you can get this behavior by just adding Philanthropist as an Optional passive, which will allow it to be included as a target passive for children |
I think that the 'Philanthropist' trait reduction is not taken into account in the software; it could be nice if it were.
The text was updated successfully, but these errors were encountered: