-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roller Mechanism incorrectly displays a second roller representing its containment position #45
Comments
This issue also applies to clothing items on hangers eg: The game uses animation information to determine whether some sprites (such as the top part of the roller mechanism) should be able to be seen in game, with "fade max" set to 0. Animations can't be seen when an item is contained, so I think that's why the sprites become visible again once contained. Clothing sprites can be marked as invisWorn to prevent them showing on the character sprite while they are wearing the clothing item. The reason clothing items with multiple sprites do not exhibit the same issue as the roller or clothing on hangers, is that the processor does a check on whether the item is clothing, and if so, filters sprites accordingly, taking invisWorn into account. twotech/process/src/SpriteProcessor.js Lines 38 to 44 in 73d2caf
Possible fix: |
The game already handles this scenario, and twotech should be assumed to be an unrelated program. Twotech should implement the same mechanism that the game does to hide the sprites. |
The game isn't exactly hiding the sprites. It's using a work around (in a possibly unintended way). Essentially the object is animated, but all that animation does is continually completely fade out the sprite. Animations are stored separately, and as far as I can see, not part of the data twotech processes. A much larger change would need to be implemented to give it access to that data, as well as a way to process that into showing the first frame for example. |
Roller mechanism should not display as a double image as shown below.
https://twotech.twohoursonelife.com/2263-Roller-Mechanism
![image](https://private-user-images.githubusercontent.com/131164516/329864134-0dea5ef3-6de8-47ba-bfc9-d9944e3d0535.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTU2NTUsIm5iZiI6MTczOTE1NTM1NSwicGF0aCI6Ii8xMzExNjQ1MTYvMzI5ODY0MTM0LTBkZWE1ZWYzLTZkZTgtNDdiYS1iZmM5LWQ5OTQ0ZTNkMDUzNS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjQyMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MGI4ODQ3NjYzNTM3YmM4ZmE3NGUyM2MwNzM4ZWM2OTVmMTRiNTFjOWNhMjNiMDA2MDA0OTk0NzhkMTRiYTI0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.ERLgDmIJY8tUiBjv4sydLVghlZdRwPcD65nEasmmuFI)
Note: this issue is not present on Onetech:
![image](https://private-user-images.githubusercontent.com/131164516/329864168-26ffc3b1-5340-4dfe-86d7-057cf0ff362e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTU2NTUsIm5iZiI6MTczOTE1NTM1NSwicGF0aCI6Ii8xMzExNjQ1MTYvMzI5ODY0MTY4LTI2ZmZjM2IxLTUzNDAtNGRmZS04NmQ3LTA1N2NmMGZmMzYyZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMFQwMjQyMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03OGM3NDY4OTNlNzFhNTIzOWZjMjYzNjhlNzZhNThlNDA2MjZmYWM5ZTJlNzM0ZWU1NmU3ZTkxMjFiOWY2NTUxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.aTb1_nQzfcxK_NypJX02G3ImiHSNqgwOOL0_8vl2QtU)
https://onetech.info/2263-Roller-Mechanism
The text was updated successfully, but these errors were encountered: