Skip to content

Commit a79a30e

Browse files
author
Young Fan
committedJan 9, 2017
More updates for Swift 3 (changed NSError to Error and NSURL to URL)
1 parent c7d831b commit a79a30e

8 files changed

+17
-17
lines changed
 

‎AnalyticsKit.swift

+5-5
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import Foundation
1414
func logEvent(_ event: String, withProperties properties: [String: Any], timed: Bool)
1515
func endTimedEvent(_ event: String, withProperties properties: [String: Any])
1616
func logError(_ name: String, message: String?, exception: NSException?)
17-
func logError(_ name: String, message: String?, error: NSError?)
17+
func logError(_ name: String, message: String?, error: Error?)
1818
}
1919

2020
class AnalyticsKit: NSObject {
@@ -104,7 +104,7 @@ class AnalyticsKit: NSObject {
104104
channel(DefaultChannel).logError(name, message: message, exception: exception)
105105
}
106106

107-
class func logError(_ name: String, message: String?, error: NSError?) {
107+
class func logError(_ name: String, message: String?, error: Error?) {
108108
channel(DefaultChannel).logError(name, message: message, error: error)
109109
}
110110

@@ -214,8 +214,8 @@ class AnalyticsKitChannel: NSObject, AnalyticsKitProvider {
214214
}
215215
}
216216

217-
func logError(_ name: String, message: String?, error: NSError?) {
218-
AKLog("\(channelName) \(name) message: \(message ?? "nil") error: \(error?.description ?? "nil")")
217+
func logError(_ name: String, message: String?, error: Error?) {
218+
AKLog("\(channelName) \(name) message: \(message ?? "nil") error: \(error?.localizedDescription ?? "nil")")
219219
for provider in providers {
220220
provider.logError(name, message: message, error: error)
221221
}
@@ -224,7 +224,7 @@ class AnalyticsKitChannel: NSObject, AnalyticsKitProvider {
224224

225225
private func AKLog(_ message: String, _ file: String = #file, _ function: String = #function, _ line: Int = #line) {
226226
#if DEBUG
227-
print("\(NSURL(string: file)?.lastPathComponent ?? "") \(function)[\(line)]: \(message)")
227+
print("\(URL(string: file)?.lastPathComponent ?? "") \(function)[\(line)]: \(message)")
228228
#else
229229
if message == "" {
230230
// Workaround for swift compiler optimizer crash

‎AnalyticsKitDebugProvider.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ class AnalyticsKitDebugProvider: NSObject, AnalyticsKitProvider {
2626
showAlert(message)
2727
}
2828

29-
func logError(_ name: String, message: String?, error: NSError?) {
30-
let message = "\(name)\n\n\(message ?? "nil")\n\n\(error?.description ?? "nil")"
29+
func logError(_ name: String, message: String?, error: Error?) {
30+
let message = "\(name)\n\n\(message ?? "nil")\n\n\(error?.localizedDescription ?? "nil")"
3131
showAlert(message)
3232
}
3333

‎Providers/AdjustIO/AnalyticsKitAdjustIOProvider.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class AnalyticsKitAdjustIOProvider: NSObject, AnalyticsKitProvider {
6060

6161
}
6262

63-
func logError(_ name: String, message: String?, error: NSError?) {
63+
func logError(_ name: String, message: String?, error: Error?) {
6464

6565
}
6666

‎Providers/Crashlytics/AnalyticsKitCrashlyticsProvider.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ class AnalyticsKitCrashlyticsProvider: NSObject, AnalyticsKitProvider {
4949
clsLog("error: \(name) message: \(message ?? "nil") exception: \(exception?.description ?? "nil")")
5050
}
5151

52-
func logError(_ name: String, message: String?, error: NSError?) {
53-
clsLog("error: \(name) message: \(message ?? "nil") error: \(error?.description ?? "nil")")
52+
func logError(_ name: String, message: String?, error: Error?) {
53+
clsLog("error: \(name) message: \(message ?? "nil") error: \(error?.localizedDescription ?? "nil")")
5454
}
5555

5656
fileprivate func clsLog(_ message: String) {

‎Providers/Flurry/AnalyticsKitFlurryProvider.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ class AnalyticsKitFlurryProvider: NSObject, AnalyticsKitProvider {
7272
}
7373
}
7474

75-
func logError(_ name: String, message: String?, error: NSError?) {
75+
func logError(_ name: String, message: String?, error: Error?) {
7676
runOnMainThread {
7777
Flurry.logError(name, message: message, error: error)
7878
}

‎Providers/Flurry/AnalyticsKitWatchExtensionFlurryProvider.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ class AnalyticsKitWatchExtensionFlurryProvider: NSObject, AnalyticsKitProvider {
4545

4646
}
4747

48-
func logError(_ name: String, message: String?, error: NSError?) {
48+
func logError(_ name: String, message: String?, error: Error?) {
4949

5050
}
5151

‎Providers/Google Analytics/AnalyticsKitGoogleAnalyticsProvider.swift

+3-3
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,13 @@ class AnalyticsKitGoogleAnalyticsProvider: NSObject, AnalyticsKitProvider {
7373
}
7474

7575
func logError(_ name: String, message: String?, exception: NSException?) {
76-
// isFatal = NO, presume here, Exeption is not fatal.
76+
// isFatal = NO, presume here, Exception is not fatal.
7777
let dict = GAIDictionaryBuilder.createException(withDescription: message ?? "nil", withFatal: 0).build() as [NSObject: AnyObject]
7878
tracker.send(dict)
7979
}
8080

81-
func logError(_ name: String, message: String?, error: NSError?) {
82-
// isFatal = NO, presume here, Exeption is not fatal.
81+
func logError(_ name: String, message: String?, error: Error?) {
82+
// isFatal = NO, presume here, Exception is not fatal.
8383
let dict = GAIDictionaryBuilder.createException(withDescription: message ?? "nil", withFatal: 0).build() as [NSObject: AnyObject]
8484
tracker.send(dict)
8585
}

‎Providers/mParticle/AnalyticsKitMParticleProvider.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -85,13 +85,13 @@ class AnalyticsKitMParticleProvider: NSObject, AnalyticsKitProvider {
8585
}
8686
}
8787

88-
func logError(_ name: String, message: String?, error: NSError?) {
88+
func logError(_ name: String, message: String?, error: Error?) {
8989
var eventInfo = [String: Any]()
9090
if let message = message {
9191
eventInfo["message"] = message
9292
}
9393
if let error = error {
94-
eventInfo["error"] = error.description
94+
eventInfo["error"] = error.localizedDescription
9595
}
9696
MParticle.sharedInstance().logError(name, eventInfo: eventInfo)
9797
}

0 commit comments

Comments
 (0)
Please sign in to comment.