From 24689e87620f6181917866e065d4e59fc35477bb Mon Sep 17 00:00:00 2001 From: Johan Herland Date: Sat, 4 Mar 2023 02:59:32 +0100 Subject: [PATCH] check: Remove compare_imports_to_dependencies() No longer in use. --- fawltydeps/check.py | 20 ------------------- tests/test_compare_imports_to_dependencies.py | 15 -------------- 2 files changed, 35 deletions(-) diff --git a/fawltydeps/check.py b/fawltydeps/check.py index 0c4f1aa3f..a5b9a893a 100644 --- a/fawltydeps/check.py +++ b/fawltydeps/check.py @@ -136,23 +136,3 @@ def calculate_unused( UnusedDependency(name, [dep.source for dep in deps]) for name, deps in groupby(unused, key=lambda d: d.name) ] - - -def compare_imports_to_dependencies( - imports: List[ParsedImport], - dependencies: List[DeclaredDependency], - settings: Settings, -) -> Tuple[Dict[str, Package], List[UndeclaredDependency], List[UnusedDependency]]: - """Compares imports to dependencies. - - Returns set of undeclared imports and set of unused dependencies. - For undeclared dependencies returns files and line numbers - where they were imported in the code. - """ - # TODO consider empty list of dependency to import - packages = resolve_dependencies(dep.name for dep in dependencies) - return ( - packages, - calculate_undeclared(imports, packages, settings), - calculate_unused(imports, dependencies, packages, settings), - ) diff --git a/tests/test_compare_imports_to_dependencies.py b/tests/test_compare_imports_to_dependencies.py index fc1bb988b..e9b0768cd 100644 --- a/tests/test_compare_imports_to_dependencies.py +++ b/tests/test_compare_imports_to_dependencies.py @@ -9,7 +9,6 @@ LocalPackageLookup, calculate_undeclared, calculate_unused, - compare_imports_to_dependencies, resolve_dependencies, ) from fawltydeps.settings import Settings @@ -261,17 +260,3 @@ def test_calculate_unused(vector): vector.imports, vector.declared_deps, vector.expect_resolved_deps, settings ) assert actual == vector.expect_unused_deps - - -@pytest.mark.parametrize("vector", [pytest.param(v, id=v.id) for v in testdata]) -def test_compare_imports_to_dependencies(vector): - settings = Settings( - ignore_unused=vector.ignore_unused, ignore_undeclared=vector.ignore_undeclared - ) - actual = compare_imports_to_dependencies( - vector.imports, vector.declared_deps, settings - ) - actual_resolved_deps, actual_undeclared_deps, actual_unused_deps = actual - assert actual_resolved_deps == vector.expect_resolved_deps - assert actual_undeclared_deps == vector.expect_undeclared_deps - assert actual_unused_deps == vector.expect_unused_deps