-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pagination color #31477
Comments
I'm pretty sure The problem of creating color variants of each component is that it increases CSS bundle size (and therefore impacts performances). |
pagination is most common and most useful features in all the blog type website. Hope, we will see this class soon. |
i agree with @dev0mhm . adding this small feature wont effect CSS bundle size in a huge manner. |
I agree with @dev0mhm, if do you interesting I can to do this pull request |
aye |
It's not but I don't know how the core team decides about adding (or not adding) that kind of things to library core. It doesn't look like a popular demand/feature to me so I'm advocating a mixin (you can use to generate colored pagination yourself) without adding this to the core of the lib. |
I have create a pull request with mixin and class with theme colors, If interested, I can just add the mixin @Deckluhm |
Usually, the pagination should look the same throughout the site. |
Pagination colors are customizable through Sass variables, both in v4 and v5. This has not been requested much, and as @axzx said I'm not sure it should be part of the core. FWIW, customization might be easier soon whilst v5 moves to CSS custom properties. Using custom properties for pagination colors would make adding variant much easier. |
okasss |
I agree with @ffoodd, I think it's a good idea to change the color of pagination with CSS variables. I think this is generally a good direction for Bootstrap to keep going in, as it is getting to be rather large. |
If will implement this #29853 with new versions of SCSS we could add new variants with additional colors without Bootstrap code change like:
or
|
Thanks, but for now we'll pass on adding color schemes for this. Would rather implement CSS vars for configuring the colors and direct folks to Sass variables for more. |
Introduce different pagination color.Currently pagination only support primary color.
Like
'.pagination .pagination-primary'
The text was updated successfully, but these errors were encountered: