Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate theme-color, gray, color functions #27377

Closed
MartijnCuppens opened this issue Oct 8, 2018 · 3 comments
Closed

Deprecate theme-color, gray, color functions #27377

MartijnCuppens opened this issue Oct 8, 2018 · 3 comments
Labels

Comments

@MartijnCuppens
Copy link
Member

As suggested here #27338 (comment), we can deprecate the theme-color, gray, color functions. The color and gray functions are not used by Bootstrap and it's easy to remove the theme-color dependency. These functions don't really add anything to Bootstrap.

With a small changes we can make Bootstrap independent of these functions and throw a warning like we did here, so we can deprecate them in a next major release:

@if ($ignore-warning != true) {
@warn "The `text-hide()` mixin has been deprecated as of v4.1.0. It will be removed entirely in v5.";
}

@XhmikosR
Copy link
Member

Personally I'd say go for this, but perhaps wait for @mdo and @andresgalante to chime in.

We just need to make sure we don't introduce breaking changes in minor/patch releases.

@XhmikosR XhmikosR added the css label Oct 11, 2018
@XhmikosR XhmikosR changed the title Deprecated theme-color, gray, color functions Deprecate theme-color, gray, color functions Oct 20, 2018
@mdo
Copy link
Member

mdo commented Dec 17, 2018

I think the expectation I had here was that functions like theme-color would generate the different shades of each color, allowing us to easily create a family of one color's shades (e.g., our $gray-100 through $gray-900). I imagine we can nuke these in v5 if we're not using them though.

@mdo mdo added the v5 label Dec 17, 2018
@mdo
Copy link
Member

mdo commented Apr 11, 2020

I believe this was resolved.

@mdo mdo closed this as completed Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants