Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass precision documentation #27201

Closed
XhmikosR opened this issue Sep 10, 2018 · 5 comments
Closed

Sass precision documentation #27201

XhmikosR opened this issue Sep 10, 2018 · 5 comments

Comments

@XhmikosR
Copy link
Member

It seems we are using precision: 6 for node-sass, while its default is 5. Shouldn't we document this in the theming page and/or somewhere else?

/CC @mdo @andresgalante @MartijnCuppens

@XhmikosR XhmikosR added the v4 label Sep 10, 2018
@Johann-S Johann-S added the docs label Sep 10, 2018
@MartijnCuppens
Copy link
Member

Yes. The theming page seems to be the best place for this indeed.

@andresgalante
Copy link
Collaborator

Do we really need the adding character? would it make any difference if we just reduce it to 5?

@XhmikosR
Copy link
Member Author

I guess this was chosen on purpose at some point. /CC @mdo

@MartijnCuppens
Copy link
Member

MartijnCuppens commented Sep 11, 2018

This was probably done to prevent some rounding issues.
See https://codepen.io/MartijnCuppens/pen/bxvNPV (5 digits):
image
And https://codepen.io/MartijnCuppens/pen/gdebVY (6 digits):
image

Browser: chrome, macOS

Edit: also tested this on Firefox & Safari, same results

@XhmikosR
Copy link
Member Author

So, the question is, where should we add this info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants