Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1 Accordion Responsive Bug #26954

Closed
justinledelson opened this issue Jul 24, 2018 · 2 comments
Closed

4.1 Accordion Responsive Bug #26954

justinledelson opened this issue Jul 24, 2018 · 2 comments
Labels

Comments

@justinledelson
Copy link

https://getbootstrap.com/docs/4.1/components/collapse/

The example accordion is not responsive. When the accordion title is longer than the viewport it doesn't break. Instead it overflows and increases the page width.

You can see the bug here:
http://cloud.codecowboy.com/1Q3X2w2Y2S40

Suggested Fix
.accordion h5 .btn {white-space: normal;}

  • Windows 10
  • Chrome Version 67.0.3396.99 (Official Build) (64-bit)
@sts-ryan-holton
Copy link
Contributor

I'd actually agree with @justinledelson. This isn't really user friendly, and the issue is related to the .btn class which contains the following:

white-space: nowrap;

I'm not sure why we add this, and if it is absolutely necessary I'd suggest adding it below the md media query, or rather, remove by default, and add on the md breakpoint and upwards.

@MartijnCuppens
Copy link
Member

I wouldn't mess with media queries to much, this may lead to unexpected results. IMO we should just remove this line, the .text-nowrap class can be used to achieve this behaviour if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants