Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Publisher Confirms #15

Open
mk-pmb opened this issue Sep 14, 2018 · 2 comments
Open

Support Publisher Confirms #15

mk-pmb opened this issue Sep 14, 2018 · 2 comments

Comments

@mk-pmb
Copy link
Contributor

mk-pmb commented Sep 14, 2018

Since the docs say exchange.publish returns a promise, I thought I could rely on that to determine when it's ok to close the connection. Looks like it's not, at least not when I have other unrelated publisher connections running at the same time. At least Wireshark can't see any feedback from the server that would warrant the promise being resolved, and nonetheless, it is resolved. When I subsequently close the connection, my last message is lost.

Could you maybe use Publisher Confirms to make sure the promise only resolves once the server got the message? Please also document whether I can use the same publisher channel to send lots of messages (awaiting all their confirms later) and have them be sent in a large burst instead of one by one. cf. Ack Latency for Persistent Messages

Also please document whether amqp-a-p will take care of potential problems with Delivery Tag approaching Number.MAX_SAFE_INTEGER,

@fred-o
Copy link
Contributor

fred-o commented Nov 29, 2018

There was a bug in exchange.publish() for version 5.x. It is hopefully fixed in version 5.0.2

@mk-pmb
Copy link
Contributor Author

mk-pmb commented Dec 1, 2018

Thanks! Would be nice if the docs could soon explain what meaning is intended in the promise returned from exchange.publish, i.e. when it is expected to be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants