Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to opt-out of auto-parsing JSON #12

Open
mk-pmb opened this issue Mar 22, 2018 · 3 comments
Open

Add option to opt-out of auto-parsing JSON #12

mk-pmb opened this issue Mar 22, 2018 · 3 comments

Comments

@mk-pmb
Copy link
Contributor

mk-pmb commented Mar 22, 2018

Just discovered the JSON auto-parsing feature in src/compat-node-amqp.coffee. There should be an opt-out so people can process messages whose contentType is lying.

@fred-o
Copy link
Contributor

fred-o commented Apr 18, 2018

That sound totally reasonable. I'm thinking about whether this should be a global option for the whole client object.

@mk-pmb
Copy link
Contributor Author

mk-pmb commented Jul 19, 2018

It's been annoying for a while now. :-( Do you intend to fix this any time soon?
If in doubt, add the opt-out option where it has least impact on legacy code, e.g. at the .subscribe() call.

@mk-pmb
Copy link
Contributor Author

mk-pmb commented Dec 1, 2018

Any news on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants