Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mask option to stats #346

Open
petrelharp opened this issue Aug 27, 2019 · 4 comments
Open

add mask option to stats #346

petrelharp opened this issue Aug 27, 2019 · 4 comments
Labels
enhancement New feature or request Python API Issue is about the Python API

Comments

@petrelharp
Copy link
Contributor

petrelharp commented Aug 27, 2019

This is going to be necessary for stdpopsim. We can do it easily in python at first as I did here.

@jeromekelleher
Copy link
Member

Agreed. As discussed somewhere in #261, I think the mask argument should be a 2D numpy array with shape (N, 2) so that we would mask out two regions with something like

ts.diversity(mask=[(s1, e1), (s2, e2)])

We can use the recently added interval operations in util.py to parse these mask arguments.

@jeromekelleher
Copy link
Member

As discussed, we're not sure when these are needed though. I'm provisionally adding them to a new 0.2.3 milestone, but we can promote to 0.2.2 if we want.

@jeromekelleher jeromekelleher added this to the Python 0.2.3 milestone Aug 27, 2019
@jeromekelleher jeromekelleher added Python API Issue is about the Python API enhancement New feature or request labels Sep 29, 2020
@jeromekelleher jeromekelleher removed this from the Python upcoming milestone Sep 29, 2020
@szhan
Copy link
Member

szhan commented Jun 28, 2022

Is this feature still desired?

@jeromekelleher
Copy link
Member

Yes - but it's a can of worms. I wouldn't take it on unless you have a spare month!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python API Issue is about the Python API
Projects
None yet
Development

No branches or pull requests

3 participants