Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stats API to make options last non-output parameter #2285

Closed
jeromekelleher opened this issue May 20, 2022 · 0 comments · Fixed by #2292
Closed

Update stats API to make options last non-output parameter #2285

jeromekelleher opened this issue May 20, 2022 · 0 comments · Fixed by #2292
Labels
C API Issue is about the C API

Comments

@jeromekelleher
Copy link
Member

We're pretty consistent elsewhere on this pattern of having options be the last param non output param. When we're documenting the stats API, we need to update this, so we have eg

typedef int one_way_weighted_method(const tsk_treeseq_t *self, tsk_size_t num_weights,
    const double *weights, tsk_size_t num_windows, const double *windows, tsk_flags_t options,
   double *result);
@jeromekelleher jeromekelleher added the C API Issue is about the C API label May 20, 2022
@mergify mergify bot closed this as completed in #2292 May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Issue is about the C API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant