Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use doubling strategy for allocating memory in ragged columns? #1703

Closed
jeromekelleher opened this issue Sep 15, 2021 · 1 comment · Fixed by #1709
Closed

Use doubling strategy for allocating memory in ragged columns? #1703

jeromekelleher opened this issue Sep 15, 2021 · 1 comment · Fixed by #1709
Labels
C API Issue is about the C API
Milestone

Comments

@jeromekelleher
Copy link
Member

In #1683 we updated the default strategy for allocating memory for the fixed size table columns to use doubling.

Should we do something similar for the ragged columns like metadata? It's probably what an API user would expect I think. We should also document the tsk_individual_table_set_max_metadata_length_increment etc methods so that power users can keep control of memory, if they want to.

@jeromekelleher jeromekelleher added the C API Issue is about the C API label Sep 15, 2021
@jeromekelleher jeromekelleher added this to the C API 1.0.0 milestone Sep 15, 2021
@benjeffery
Copy link
Member

Yep, thanks for this. I had thought it while coding up the rows changes and forgot to make an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C API Issue is about the C API
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants