-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Bech32 functions #4100
Comments
Hi @satoshiotomakan, I can work on this. Which solution do you prefer? Do you have any other better solutions? |
Hi @10gic, good suggestion. I think the |
Hi @satoshiotomakan, your comment reminds me that there is one more solution: struct TWBech32;
TWString *_Nonnull TWBech32Encode(TWString* _Nonnull hrp, TWData *_Nonnull data);
TWData* _Nullable TWBech32Decode(TWString* _Nonnull string);
TWString *_Nonnull TWBech32EncodeM(TWString* _Nonnull hrp, TWData *_Nonnull data); // bip350 Variant
TWData* _Nullable TWBech32DecodeM(TWString* _Nonnull string); // bip350 Variant It's hard to choose solution 1 and solution 3. |
Thank you for the PR @10gic, it's merged finally :) |
Exporting the bech32 related functions would increase the utility of this library.
For example, Sui uses bech32 to encode its private keys. https://github.com/sui-foundation/sips/blob/main/sips/sip-15.md
Is your feature request related to a problem? Please describe.
N/A
Describe the solution you'd like
Solution 1:
Describe alternatives you've considered
Solution 2:
Checklist
Resources
Resources link
https://github.com/bitcoin/bips/blob/master/bip-0173.mediawiki
https://github.com/bitcoin/bips/blob/master/bip-0350.mediawiki
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: