Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

forking: setting a contract value to true that was previously false fails #663

Closed
davidmurdoch opened this issue Nov 17, 2020 · 3 comments
Closed

forking: setting a contract value to true that was previously false fails #663

davidmurdoch opened this issue Nov 17, 2020 · 3 comments
Assignees
@davidmurdoch
Labels
bug forking priority4 📋

Comments

@davidmurdoch
Copy link
Member

Or at least fails when later reading that value back.

As reported by Alejandro Santander: https://twitter.com/gnidan/status/1327511669203996672
@davidmurdoch
Copy link
Member Author

Example:
https://github.com/Synthetixio/synthetix/blob/e94c5c101ebb14bec1a89d8b5d6c1a84ab21fdfc/test/prod/Synthetix.prod.js#L341-L343

fails.

Interestingly, calling await vSynth.settle(user1, { from: user1 }) twice instead of just the once time causes the test to pass.

@davidmurdoch
Copy link
Member Author

possibly related to #658

@davidmurdoch davidmurdoch moved this to Inbox in Ganache Jul 19, 2022
@davidmurdoch davidmurdoch moved this from Inbox to Backlog in Ganache Jul 19, 2022
@davidmurdoch davidmurdoch moved this from Backlog to In Progress in Ganache Jul 19, 2022
@davidmurdoch
Copy link
Member Author

Closing as Ganache v7+ now has sophisticated change tracking built into forking that should prevent this sort of error. If you, dear reader from the future, experience this sort of error please open a new issues with the details!

Repository owner moved this from In Progress to Done in Ganache Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidmurdoch davidmurdoch

Labels
bug forking priority4 📋
Projects
Ganache
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gnidan @davidmurdoch