Optimize: Modify log module #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
===================================================
- Coverage 81.78800% 81.72894% -0.05907%
===================================================
Files 855 855
Lines 33736 33720 -16
===================================================
- Hits 27592 27559 -33
- Misses 6144 6161 +17
|
trpc-admin
reviewed
Nov 17, 2023
trpc/util/log/logging.h
Outdated
| @@ -50,7 +50,7 @@ constexpr char kTrpcLogCacheStringDefault[] = "default"; | |||
| /// @param msg Log message | |||
| #define TRPC_LOG(instance, level, msg) \ | |||
| do { \ | |||
| const auto& __TRPC_LOG_INSTANCE__ = ::trpc::LogFactory::GetInstance()->Get(); \ | |||
| const auto& __TRPC_LOG_INSTANCE__ = ::trpc::LogFactory::GetInstance() -> Get(); \ | |||
8bd906e to
c261d3a
Compare
trpc-admin
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.