BugFix(stream): fix crash when peer send reset stream frame but has n…

…o error message (#82)
trpc-group · Nov 21, 2023 · 0a23ad4 · 0a23ad4
1 parent 1f475f3
commit 0a23ad4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/trpc/stream/trpc/trpc_client_stream.cc b/trpc/stream/trpc/trpc_client_stream.cc
@@ -336,8 +336,12 @@ RetCode TrpcClientStream::HandleClose(StreamRecvMessage&& msg) {
     // Close (RESET) due to an exception, so there is no need to check the stream status.
     // Notify the business that the stream has failed.
     SetState(State::kClosed);
+    if (status.OK()) {
+      // Normally, the reset frame will carry error code. But if it doesn't exist, we add an unknown error.
+      status.SetFrameworkRetCode(TrpcRetCode::TRPC_STREAM_UNKNOWN_ERR);
+      status.SetErrorMessage("stream reset recive, but unable to get error message");
+    }
     OnError(status);
-    std::cout << "stream error occurs" << std::endl;
     return RetCode::kError;
   }
 

diff --git a/trpc/stream/trpc/trpc_server_stream.cc b/trpc/stream/trpc/trpc_server_stream.cc
@@ -175,6 +175,11 @@ RetCode TrpcServerStream::HandleClose(StreamRecvMessage&& msg) {
   if (reset) {
     // When closing (RESET) due to an exception, there is no need to check the stream state.
     SetState(State::kClosed);
+    if (status.OK()) {
+      // Normally, the reset frame will carry error code. But if it doesn't exist, we add an unknown error.
+      status.SetFrameworkRetCode(TrpcRetCode::TRPC_STREAM_UNKNOWN_ERR);
+      status.SetErrorMessage("stream reset recive, but unable to get error message");
+    }
     OnError(status);
     return RetCode::kError;
   }