Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new feature: put exception as a param to event_failed #146

Open
lksv opened this issue Aug 26, 2015 · 1 comment
Open

new feature: put exception as a param to event_failed #146

lksv opened this issue Aug 26, 2015 · 1 comment
Labels

Comments

@lksv
Copy link
Contributor

lksv commented Aug 26, 2015

I may want to propagate some exceptions and others I may want to handle in event_failed callback.

I am not sure whether catching exception at all is good idea. Maybe best solution would be to re-raise exception after calling event_failed.

@troessner
Copy link
Owner

Sorry for the late reply, I kind of missed this one!

I may want to propagate some exceptions and others I may want to handle in event_failed callback.

Yes, makes sense. Care for a pull request? ;)

I am not sure whether catching exception at all is good idea. Maybe best solution would be to re-raise exception after calling event_failed.

I'm not so sure about this. But then again, if we pass the exception to event_failed it's up to you if you want to just re-raise yourself at the end of the callback. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants