fix: callback with fully resolved route name (after adding a route)

troch · Dec 26, 2016 · ca64573 · ca64573
1 parent dd72875
commit ca64573
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/modules/RouteNode.js b/modules/RouteNode.js
@@ -145,7 +145,13 @@ export default class RouteNode {
             }
         }
 
-        if (originalRoute) cb(originalRoute);
+        if (originalRoute) {
+            const fullName = route.getParentSegments([ route ]).map((_) => _.name).join('.');
+            cb({
+                ...originalRoute,
+                name: fullName
+            });
+        }
 
         return this;
     }

diff --git a/test/main.js b/test/main.js
@@ -42,8 +42,8 @@ describe('RouteNode', function () {
 
         node.add(routes, function(route) {
             i = i + 1;
-            if (i === 1) route.should.equal(routeA);
-            if (i === 2) route.should.equal(routeB);
+            if (i === 1) route.should.eql(routeA);
+            if (i === 2) route.should.eql(routeB);
         });
 
         i.should.not.equal(0);
@@ -52,8 +52,8 @@ describe('RouteNode', function () {
 
         var node = new RouteNode('', '', routes, function(route) {
             i = i + 1;
-            if (i === 1) route.should.equal(routeA);
-            if (i === 2) route.should.equal(routeB);
+            if (i === 1) route.should.eql(routeA);
+            if (i === 2) route.should.eql(routeB);
         });
 
         i.should.not.equal(0);