Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectorMetadata #getTableStatistics and #getTableProperties may do repeated throw-away computation #10980

Open
Praveen2112 opened this issue Feb 8, 2022 · 1 comment
Open

ConnectorMetadata #getTableStatistics and #getTableProperties may do repeated throw-away computation #10980

Praveen2112 opened this issue Feb 8, 2022 · 1 comment

Comments

@Praveen2112
Copy link
Member

In HiveMetadata#getTableProperties we would force load the partition information if they are not available in HiveTableHandle and they are discarded post that. The partition information are loaded once again during split creation, so it would be better if we could provide a way to update ConnectorTableHandle when we are compute table properties.
@Praveen2112 Praveen2112 mentioned this issue Feb 8, 2022
Merged
@findepi
Copy link
Member

findepi commented Feb 9, 2022

Allow ConnectorMetadata#getTableProperties to update ConnectorTableHandle

that's prescribes a solution, and not necessarily the right one.
As i said in #10215 (comment), let's have an issue formulated around the problem.

@findepi findepi changed the title Allow ConnectorMetadata#getTableProperties to update ConnectorTableHandle ConnectorMetadata#getTableProperties may do repeated throw-away computation Feb 9, 2022
@findepi findepi changed the title ConnectorMetadata#getTableProperties may do repeated throw-away computation ConnectorMetadata #getTableStatistics and #getTableProperties may do repeated throw-away computation Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@findepi @Praveen2112