Only set log level for the root logger #434
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @guerremdq |
hashhar
force-pushed
the
hashhar/default-logger-improvement
branch
from
3b1eb3d to
7c09190
Compare
Before this change we called `setLevel` on each logger with level set to
INFO. This meant that it was not possible to change log level for all
child modules by doing something like
`logging.getLogger('trino').setLevel(logging.DEBUG)` because the child
loggers had explicit levels set already. It instead required us to
change log levels for each module (`trino.client`, `trino.dbapi`,
`trino.auth` etc.) separately.
After this change only the root logger `trino` has a default level set.
Other child loggers inherit from it. So now the default log level for
all modules can be changed by doing
`logging.getLogger('trino').setLevel(logging.DEBUG)` for example.
hashhar
force-pushed
the
hashhar/default-logger-improvement
branch
from
7c09190 to
57074aa
Compare
hovaesco
approved these changes
Dec 22, 2023
ebyhr
approved these changes
Dec 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change we called
setLevelon each logger with level set to INFO. This meant that it was not possible to change log level for all child modules by doing something likelogging.getLogger('trino').setLevel(logging.DEBUG)because the child loggers had explicit levels set already. It instead required us to change log levels for each module (trino.client,trino.dbapi,trino.authetc.) separately.After this change only the root logger
trinohas a default level set. Other child loggers inherit from it. So now the default log level for all modules can be changed by doinglogging.getLogger('trino').setLevel(logging.DEBUG)for example.Non-technical explanation
Make it easy to configure log level for all modules at once.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Fixes #424