Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_rfc_1738_quote is no longer available in sqlalchemy 1.4.42 #273

Closed
1 task done
tschager opened this issue Oct 19, 2022 · 1 comment · Fixed by #274
Closed
1 task done

_rfc_1738_quote is no longer available in sqlalchemy 1.4.42 #273

tschager opened this issue Oct 19, 2022 · 1 comment · Fixed by #274

Comments

@tschager
Copy link

Expected behavior

Usage of trino with sqlalchemy 1.4.42.

Actual behavior

Starting from sqlalchemy 1.4.42, the function _rfc_1738_quote has be renamed. This leads to an ImportError when using trino with this version of sqlalchemy.

trino-python-client/trino/sqlalchemy/util.py

Line 6 in 59473d7

from sqlalchemy.engine.url import _rfc_1738_quote # noqa

Steps To Reproduce

Import trino 0.318.0 and sqlalchemy 1.4.42

Log output

No response

Operating System

Debian GNU/Linux 11

Trino Python client version

0.318.0

Trino Server version

400

Python version

3.10.0

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@tschager
Copy link
Author

snowflake-sqlalchemy solved this issue by implementing the version (a two-liner) directly instead of importing it

https://github.com/snowflakedb/snowflake-sqlalchemy/pull/351/files

@hovaesco hovaesco mentioned this issue Oct 20, 2022
Merged
@mederka mederka mentioned this issue Nov 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a compatibility issue with SQLAlchemy v1.4.42 hovaesco/trino-python-client
1 participant
@tschager