-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tpetra: cmake logic for detecting GPU-aware MPI only works for OpenMPI variants #12468
Comments
Are there currently GPU architectures where the MPI is not GPU aware? Should the default be to assume GPU-aware MPI? |
As discussed offline: Assume GPU-aware by default is reasonable. Consider removing the ompi specific special sauce. |
I assume we'd need to deprecate this? |
@jhux2 I mean, this isn't something you can control, so you can't really deprecate it. |
Will the merge of #12517, Tpetra now defaults to assuming that MPI is GPU aware. If an application is using an MPI that isn't GPU aware, the app should either configure Trilinos with
or at run time set the environment variable
|
Just a heads up. This change caused a lot of testing failures inside sandia. The internal cuda test machines don't seem to have cuda aware mpi installed. The failures are seg faults with no real info, so it is not easy to debug. You might want to send out an email to the trilinos lists mentioning this change. |
@jhux2 Can we close this? |
Bug Report
The Tpetra Cmake logic for setting
Tpetra_ASSUME_GPU_AWARE_MPI
assumes the existence ofompi_info
. The latter is specific to OpenMPI.Description
Frontier uses an MPICH variant. Tpetra incorrectly sets
Tpetra_ASSUME_GPU_AWARE_MPI
to false (if the option isn't explicitly set on the commmand line).The text was updated successfully, but these errors were encountered: