Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Allow PRs to be manually merged once they are approved and pass tests #10918

Closed
tasmith4 opened this issue Aug 23, 2022 · 2 comments
Closed
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug

Comments

@tasmith4
Copy link
Contributor

tasmith4 commented Aug 23, 2022

Enhancement

@trilinos/framework @ccober6 @csiefer2 @bartlettroscoe @jhux2

Currently, my best understanding is that in order for a PR to be available to merge in GitHub (i.e. merge button is active and not grayed out), the autotester must run the tests, get a passing result, and also "inspect" the PR to note that it has been approved by another user. For various reasons, the autotester often cannot circle back to inspect a PR for hours or days, but I don't see any reason why we would want to block passing, approved PRs during this time period. The reasons for the autotester delay are often out of the control of the Framework team, i.e. Jenkins issues, machine capacity, volume of PRs, so it's reasonable to expect delays between tests passing and autotester inspection to be a regular occurrence even after the issues noted in #10858 are resolved.

As an example, #10851 has passed tests and been approved for 5 days, but due to #10917 is not being inspected by the autotester. Unless #10917 is resolved quickly, it's likely to go stale and require a retest, putting more stress on the autotester and delaying other PRs.

I'd like to request the requirement for inspection be adjusted so approval is directly checked by GitHub and not the autotester. This would allow passing, approved PRs to be manually merged by developers.

Related internal request: TRILINOS-185

@tasmith4 tasmith4 added type: enhancement Issue is an enhancement, not a bug PA: Framework Issues that fall under the Trilinos Framework Product Area labels Aug 23, 2022
@github-actions
Copy link

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label Aug 26, 2023
@github-actions
Copy link

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. PA: Framework Issues that fall under the Trilinos Framework Product Area type: enhancement Issue is an enhancement, not a bug
Projects
None yet
Development

No branches or pull requests

1 participant