Framework: Allow PRs to be manually merged once they are approved and pass tests #10918
Labels
CLOSED_DUE_TO_INACTIVITY
Issue or PR has been closed by the GitHub Actions bot due to inactivity.
MARKED_FOR_CLOSURE
Issue or PR is marked for auto-closure by the GitHub Actions bot.
PA: Framework
Issues that fall under the Trilinos Framework Product Area
type: enhancement
Issue is an enhancement, not a bug
Enhancement
@trilinos/framework @ccober6 @csiefer2 @bartlettroscoe @jhux2
Currently, my best understanding is that in order for a PR to be available to merge in GitHub (i.e. merge button is active and not grayed out), the autotester must run the tests, get a passing result, and also "inspect" the PR to note that it has been approved by another user. For various reasons, the autotester often cannot circle back to inspect a PR for hours or days, but I don't see any reason why we would want to block passing, approved PRs during this time period. The reasons for the autotester delay are often out of the control of the Framework team, i.e. Jenkins issues, machine capacity, volume of PRs, so it's reasonable to expect delays between tests passing and autotester inspection to be a regular occurrence even after the issues noted in #10858 are resolved.
As an example, #10851 has passed tests and been approved for 5 days, but due to #10917 is not being inspected by the autotester. Unless #10917 is resolved quickly, it's likely to go stale and require a retest, putting more stress on the autotester and delaying other PRs.
I'd like to request the requirement for inspection be adjusted so approval is directly checked by GitHub and not the autotester. This would allow passing, approved PRs to be manually merged by developers.
Related internal request: TRILINOS-185
The text was updated successfully, but these errors were encountered: