diff --git a/.eslintrc.js b/.eslintrc.js index d7410a09453..17252d22651 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -361,7 +361,6 @@ module.exports = { rules: { '@typescript-eslint/no-shadow': 'off', 'import/no-default-export': 'off', - '@typescript-eslint/no-unused-vars': 'off', 'no-console': 'off', 'react/jsx-no-undef': 'off', 'no-catch-shadow': 'off', diff --git a/packages/blockchain-link/src/index.ts b/packages/blockchain-link/src/index.ts index 038a1c8cab2..3ba26ef9942 100644 --- a/packages/blockchain-link/src/index.ts +++ b/packages/blockchain-link/src/index.ts @@ -50,7 +50,7 @@ const initWorker = async (settings: BlockchainSettings) => { worker.onerror = null; try { worker.terminate(); - } catch (error) { + } catch { // empty } diff --git a/packages/blockchain-link/src/workers/baseWebsocket.ts b/packages/blockchain-link/src/workers/baseWebsocket.ts index 6f55974bf5f..0132080c76e 100644 --- a/packages/blockchain-link/src/workers/baseWebsocket.ts +++ b/packages/blockchain-link/src/workers/baseWebsocket.ts @@ -42,6 +42,7 @@ export abstract class BaseWebsocket extends TypedEmitter; protected abstract ping(): Promise; + protected abstract createWebsocket(): WebSocket; constructor(options: Options) { @@ -79,7 +80,7 @@ export abstract class BaseWebsocket extends TypedEmitter extends TypedEmitter extends TypedEmitter {}); // hack; ws throws uncaughtably when there's no error listener ws.close(); - } catch (error) { + } catch { // empty } }, diff --git a/packages/blockchain-link/src/workers/electrum/devrun.ts b/packages/blockchain-link/src/workers/electrum/devrun.ts index 3c28cbb3119..a037e7fc56d 100644 --- a/packages/blockchain-link/src/workers/electrum/devrun.ts +++ b/packages/blockchain-link/src/workers/electrum/devrun.ts @@ -1,3 +1,4 @@ +/* eslint-disable @typescript-eslint/no-unused-vars */ // @ts-nocheck /// diff --git a/packages/blockchain-link/src/workers/ripple/index.ts b/packages/blockchain-link/src/workers/ripple/index.ts index 57897cfdc2e..94224e1153f 100644 --- a/packages/blockchain-link/src/workers/ripple/index.ts +++ b/packages/blockchain-link/src/workers/ripple/index.ts @@ -141,7 +141,7 @@ const getAccountInfo = async (request: Request) => account.availableBalance = new BigNumber(mempoolInfo.xrpBalance).minus(reserve).toString(); account.misc.sequence = mempoolInfo.sequence; account.history.unconfirmed = mempoolInfo.txs; - } catch (error) { + } catch { // do not throw error for mempool (ledger_index: "current") // mainnet sometimes return "error": "noNetwork", "error_message": "InsufficientNetworkMode", // TODO: investigate diff --git a/packages/blockchain-link/src/workers/solana/transactionConfirmation.ts b/packages/blockchain-link/src/workers/solana/transactionConfirmation.ts index d475248a87c..693136b658e 100644 --- a/packages/blockchain-link/src/workers/solana/transactionConfirmation.ts +++ b/packages/blockchain-link/src/workers/solana/transactionConfirmation.ts @@ -12,7 +12,7 @@ const tryConfirmBySignatureStatus = async ( const getCurrentBlockHeight = async () => { try { return await api.getBlockHeight('finalized'); - } catch (_) { + } catch { return -1; } }; diff --git a/packages/blockchain-link/tests/unit/workers.test.ts b/packages/blockchain-link/tests/unit/workers.test.ts index da4203a36fe..ee5d9649f3a 100644 --- a/packages/blockchain-link/tests/unit/workers.test.ts +++ b/packages/blockchain-link/tests/unit/workers.test.ts @@ -167,6 +167,7 @@ describe('Worker', () => { return new TinyWorker(() => { self.onmessage = () => { // @ts-expect-error undefined "x" + // eslint-disable-next-line @typescript-eslint/no-unused-vars const r = 1 / x; }; diff --git a/packages/components/src/components/animations/LottieAnimation.tsx b/packages/components/src/components/animations/LottieAnimation.tsx index a4fc0ad212a..9cc264c9651 100644 --- a/packages/components/src/components/animations/LottieAnimation.tsx +++ b/packages/components/src/components/animations/LottieAnimation.tsx @@ -48,7 +48,7 @@ export const LottieAnimation = ({ ).json(); setLottieAnimationData(animation); - } catch (error) { + } catch { // do not need to handle error } }; diff --git a/packages/connect-common/src/messageChannel/abstract.ts b/packages/connect-common/src/messageChannel/abstract.ts index a0929d80fbf..37d3161ff77 100644 --- a/packages/connect-common/src/messageChannel/abstract.ts +++ b/packages/connect-common/src/messageChannel/abstract.ts @@ -48,7 +48,9 @@ export abstract class AbstractMessageChannel< protected messageID = 0; public isConnected = false; + abstract connect(): void; + abstract disconnect(): void; private readonly handshakeMaxRetries = 5; @@ -219,7 +221,7 @@ export abstract class AbstractMessageChannel< if (!usePromise) { try { this.sendFn(message); - } catch (err) { + } catch { if (useQueue) { this.messagesQueue.push(message); } @@ -234,7 +236,7 @@ export abstract class AbstractMessageChannel< try { this.sendFn(message); - } catch (err) { + } catch { if (useQueue) { this.messagesQueue.push(message); } diff --git a/packages/connect-common/src/storage.ts b/packages/connect-common/src/storage.ts index 0adae8bf825..471405e3926 100644 --- a/packages/connect-common/src/storage.ts +++ b/packages/connect-common/src/storage.ts @@ -73,7 +73,7 @@ class Storage extends TypedEmitter { const newState = getNewState(getPermanentStorage()); localStorage.setItem(storageName, JSON.stringify(newState)); this.emit('changed', newState); - } catch (err) { + } catch { // memory storage is fallback of the last resort console.warn('long term storage not available'); memoryStorage = getNewState(memoryStorage); @@ -104,7 +104,7 @@ class Storage extends TypedEmitter { try { return getPermanentStorage(); - } catch (err) { + } catch { // memory storage is fallback of the last resort console.warn('long term storage not available'); diff --git a/packages/connect-explorer/src/actions/trezorConnectActions.ts b/packages/connect-explorer/src/actions/trezorConnectActions.ts index 07663536d19..c8ba3c357cd 100644 --- a/packages/connect-explorer/src/actions/trezorConnectActions.ts +++ b/packages/connect-explorer/src/actions/trezorConnectActions.ts @@ -123,7 +123,7 @@ export const init = try { // Verify if valid by loading core.js, if this file exists we can assume the connectSrc is valid await testLoadingScript(options.connectSrc + 'js/core.js'); - } catch (err) { + } catch { dispatch({ type: ACTIONS.ON_INIT_ERROR, payload: `Invalid connectSrc: ${options.connectSrc}`, diff --git a/packages/connect-explorer/src/pages/index.mdx b/packages/connect-explorer/src/pages/index.mdx index fc3c48f34a2..3d93a2bb29e 100644 --- a/packages/connect-explorer/src/pages/index.mdx +++ b/packages/connect-explorer/src/pages/index.mdx @@ -8,13 +8,7 @@ import styled from 'styled-components'; import Link from 'next/link'; import { spacings, spacingsPx } from '@trezor/theme'; -import { - Button, - Card as TrezorCard, - CollapsibleBox, - variables, - Paragraph, -} from '@trezor/components'; +import { Button, Card as TrezorCard, CollapsibleBox, variables } from '@trezor/components'; import IconNode from '../components/icons/IconNode'; import IconWeb from '../components/icons/IconWeb'; diff --git a/packages/connect-iframe/src/index.ts b/packages/connect-iframe/src/index.ts index 816ba439bff..9feeb5f8eba 100644 --- a/packages/connect-iframe/src/index.ts +++ b/packages/connect-iframe/src/index.ts @@ -315,7 +315,7 @@ const init = async (payload: IFrameInit['payload'], origin: string) => { // throws DOMException: The operation is insecure. _popupMessagePort = new BroadcastChannel(broadcastID); _popupMessagePort.onmessage = message => handleMessage(message); - } catch (error) { + } catch { // popup will use MessageChannel fallback communication } } diff --git a/packages/connect-popup/e2e/tests/passphrase.test.ts b/packages/connect-popup/e2e/tests/passphrase.test.ts index f38a5f9fb36..df3f759854b 100644 --- a/packages/connect-popup/e2e/tests/passphrase.test.ts +++ b/packages/connect-popup/e2e/tests/passphrase.test.ts @@ -374,7 +374,7 @@ test('passphrase mismatch', async ({ page }) => { timeout: 10000, }); await popup.click('.explain.unacquired'); - } catch (error) { + } catch { // May appear or not } diff --git a/packages/connect-popup/e2e/tests/popup-close.test.ts b/packages/connect-popup/e2e/tests/popup-close.test.ts index 91371d68c74..2849a75021b 100644 --- a/packages/connect-popup/e2e/tests/popup-close.test.ts +++ b/packages/connect-popup/e2e/tests/popup-close.test.ts @@ -188,7 +188,7 @@ test(`device disconnected during device interaction`, async ({ page, context }) try { log('waiting to click @connect-ui/error-close-button'); await popup.click("button[data-testid='@connect-ui/error-close-button']"); - } catch (error) { + } catch { // Sometimes this crashes with error that the page is already closed. } diff --git a/packages/connect-popup/e2e/tests/unchained.test.ts b/packages/connect-popup/e2e/tests/unchained.test.ts index d0045cae326..099829b8ff9 100644 --- a/packages/connect-popup/e2e/tests/unchained.test.ts +++ b/packages/connect-popup/e2e/tests/unchained.test.ts @@ -103,7 +103,7 @@ const signTransaction = async (page: Page, iteration: number) => { }); await TrezorUserEnvLink.send({ type: 'emulator-press-yes' }); await popup.waitForTimeout(501); - } catch (err) { + } catch { confirmOnTrezorScreenStilVisible = false; } } diff --git a/packages/connect-popup/src/index.tsx b/packages/connect-popup/src/index.tsx index 3953fbdff37..fa6ab80e55a 100644 --- a/packages/connect-popup/src/index.tsx +++ b/packages/connect-popup/src/index.tsx @@ -57,7 +57,7 @@ const escapeHtml = (payload: any) => { div.appendChild(document.createTextNode(JSON.stringify(payload))); return JSON.parse(div.innerHTML); - } catch (error) { + } catch { // do nothing } }; diff --git a/packages/connect-popup/src/log.tsx b/packages/connect-popup/src/log.tsx index 499042d1511..95397127d8c 100644 --- a/packages/connect-popup/src/log.tsx +++ b/packages/connect-popup/src/log.tsx @@ -103,7 +103,7 @@ const useLogWorker = (setLogs: React.Dispatch>) => { try { logWorker = new SharedWorker('./workers/shared-logger-worker.js'); - } catch (error) { + } catch { console.warn('Failed to initialize SharedWorker'); } diff --git a/packages/connect-popup/src/view/common.tsx b/packages/connect-popup/src/view/common.tsx index 4a5bcefe131..f5eeb9d3124 100644 --- a/packages/connect-popup/src/view/common.tsx +++ b/packages/connect-popup/src/view/common.tsx @@ -79,7 +79,7 @@ export const getIframeElement = () => { if (frames[i].location.host === window.location.host) { iframe = frames[i]; } - } catch (error) { + } catch { // do nothing, try next entry } } @@ -147,7 +147,7 @@ export const initMessageChannelWithIframe = async ( // otherwise close BroadcastChannel and try to use MessageChannel fallback broadcast.close(); broadcast.removeEventListener('message', handler); - } catch (error) { + } catch { // silent error. use MessageChannel as fallback communication } } diff --git a/packages/connect-web/src/iframe/index.ts b/packages/connect-web/src/iframe/index.ts index f49b47bb00e..da4fd0b4cd1 100644 --- a/packages/connect-web/src/iframe/index.ts +++ b/packages/connect-web/src/iframe/index.ts @@ -19,7 +19,7 @@ export const dispose = () => { if (instance && instance.parentNode) { try { instance.parentNode.removeChild(instance); - } catch (e) { + } catch { // do nothing } } @@ -109,7 +109,7 @@ export const init = async (settings: ConnectSettings) => { return; } - } catch (e) { + } catch { // empty } diff --git a/packages/connect-web/src/impl/core-in-iframe.ts b/packages/connect-web/src/impl/core-in-iframe.ts index 40888071e88..a4e19acbd26 100644 --- a/packages/connect-web/src/impl/core-in-iframe.ts +++ b/packages/connect-web/src/impl/core-in-iframe.ts @@ -348,7 +348,7 @@ export class CoreInIframe implements ConnectFactoryDependencies { await usb.requestDevice({ filters: config.webusb }); sendMessage(WEBEXTENSION.USB_PERMISSIONS_CLOSE, '*'); broadcastPermissionFinished(); - } catch (error) { + } catch { // empty } } diff --git a/packages/connect-web/src/webusb/index.ts b/packages/connect-web/src/webusb/index.ts index 4a53f8f6fbe..bb43f1ee252 100644 --- a/packages/connect-web/src/webusb/index.ts +++ b/packages/connect-web/src/webusb/index.ts @@ -16,7 +16,7 @@ const onload = () => { if (usb) { try { await usb.requestDevice({ filters: config.webusb }); - } catch (error) { + } catch { // empty } } diff --git a/packages/connect/e2e/__wscache__/server.js b/packages/connect/e2e/__wscache__/server.js index 7aaa191f471..9837576a51d 100644 --- a/packages/connect/e2e/__wscache__/server.js +++ b/packages/connect/e2e/__wscache__/server.js @@ -37,7 +37,7 @@ const createServer = () => { try { const data = fn(params, request); ws.send(JSON.stringify({ ...data, id: request.id })); - } catch (e) { + } catch { // empty } }; diff --git a/packages/connect/e2e/utils.ts b/packages/connect/e2e/utils.ts index f939c45603f..b943388cfe2 100644 --- a/packages/connect/e2e/utils.ts +++ b/packages/connect/e2e/utils.ts @@ -1,3 +1,4 @@ +// eslint-disable-next-line @typescript-eslint/no-unused-vars let Trezor: { getController: (testName?: string) => any; setup: (controller: any, options: any) => any; diff --git a/packages/connect/src/api/bitcoin/Fees.ts b/packages/connect/src/api/bitcoin/Fees.ts index 763e775fd59..1f41d03f33d 100644 --- a/packages/connect/src/api/bitcoin/Fees.ts +++ b/packages/connect/src/api/bitcoin/Fees.ts @@ -95,7 +95,7 @@ export class FeeLevels { Math.max(this.coinInfo.minFee, parseInt(response.feePerUnit, 10)), ).toString(), }; - } catch (error) { + } catch { // silent } @@ -147,7 +147,7 @@ export class FeeLevels { }); this.longTermFeeRate = findLowest(this.blocks); - } catch (error) { + } catch { // do not throw } diff --git a/packages/connect/src/api/common/paramsValidator.ts b/packages/connect/src/api/common/paramsValidator.ts index a749232a041..b23a0bc0882 100644 --- a/packages/connect/src/api/common/paramsValidator.ts +++ b/packages/connect/src/api/common/paramsValidator.ts @@ -42,7 +42,7 @@ export function validateParams

>(params: P, schema: validateParams(p, [{ name: field.name, type: t }]); return count + 1; - } catch (e) { + } catch { return count; } }, 0); diff --git a/packages/connect/src/api/firmware/getBinary.ts b/packages/connect/src/api/firmware/getBinary.ts index 55fbba3683b..50264a7eb43 100644 --- a/packages/connect/src/api/firmware/getBinary.ts +++ b/packages/connect/src/api/firmware/getBinary.ts @@ -17,7 +17,7 @@ export const getBinary = ({ baseUrl, btcOnly, release }: GetBinaryProps) => { export const getBinaryOptional = async (props: GetBinaryProps) => { try { return await getBinary(props); - } catch (error) { + } catch { return null; } }; diff --git a/packages/connect/src/core/index.ts b/packages/connect/src/core/index.ts index 3b4589fbff7..c5b00f281fa 100644 --- a/packages/connect/src/core/index.ts +++ b/packages/connect/src/core/index.ts @@ -718,7 +718,7 @@ const onCallDevice = async ( // (acquire > Initialize > nothing > release) try { await device.run(() => Promise.resolve(), { skipFinalReload: true }); - } catch (err) { + } catch { // ignore. on model T, this block of code is probably not needed at all. but I am keeping it here for // backwards compatibility } diff --git a/packages/connect/src/device/Device.ts b/packages/connect/src/device/Device.ts index fae95036bb3..39d46ce77d4 100644 --- a/packages/connect/src/device/Device.ts +++ b/packages/connect/src/device/Device.ts @@ -800,7 +800,7 @@ export class Device extends TypedEmitter { return await this.getCommands().typedCall('GetFirmwareHash', 'FirmwareHash', { challenge, }); - } catch (e) { + } catch { return null; } }; @@ -1111,7 +1111,7 @@ export class Device extends TypedEmitter { path: this.transportPath, onClose: true, }); - } catch (err) { + } catch { // empty } } diff --git a/packages/connect/src/device/DeviceCommands.ts b/packages/connect/src/device/DeviceCommands.ts index 3612410b4ea..ae99de4c7e3 100644 --- a/packages/connect/src/device/DeviceCommands.ts +++ b/packages/connect/src/device/DeviceCommands.ts @@ -46,7 +46,7 @@ const assertType = (res: DefaultPayloadMessage, resType: MessageKey | MessageKey const generateEntropy = (len: number) => { try { return randomBytes(len); - } catch (err) { + } catch { throw ERRORS.TypedError( 'Runtime', 'generateEntropy: Environment does not support crypto random', @@ -564,7 +564,7 @@ export class DeviceCommands { await createTimeoutPromise(1); await this.device.acquire(); await cancelPrompt(this.device, false); - } catch (err) { + } catch { // ignore whatever happens } } else { diff --git a/packages/connect/src/utils/addressUtils.ts b/packages/connect/src/utils/addressUtils.ts index fe6d45f6518..339ff1f4672 100644 --- a/packages/connect/src/utils/addressUtils.ts +++ b/packages/connect/src/utils/addressUtils.ts @@ -11,7 +11,7 @@ const isValidBase58Address = (address: string, network: BitcoinNetworkInfo['netw if (decoded.version !== network.pubKeyHash && decoded.version !== network.scriptHash) { return false; } - } catch (e) { + } catch { return false; } @@ -25,7 +25,7 @@ const isValidBech32Address = (address: string, network: BitcoinNetworkInfo['netw if (decoded.prefix !== network.bech32) { return false; } - } catch (e) { + } catch { return false; } diff --git a/packages/request-manager/src/torControlPort.ts b/packages/request-manager/src/torControlPort.ts index c4462819add..a309a2b3d97 100644 --- a/packages/request-manager/src/torControlPort.ts +++ b/packages/request-manager/src/torControlPort.ts @@ -69,7 +69,7 @@ export class TorControlPort { let cookieString; try { cookieString = await getCookieString(this.options.torDataDir); - } catch (error) { + } catch { reject(new Error('TOR control port control_auth_cookie cannot be read')); } const serverNonce = authchallengeResponse[2]; @@ -119,7 +119,7 @@ export class TorControlPort { } try { return !!this.write('GETINFO'); - } catch (error) { + } catch { return false; } } diff --git a/packages/suite-data/src/guide/parser.ts b/packages/suite-data/src/guide/parser.ts index 6e2b25ea4a7..3dfaf61eb33 100644 --- a/packages/suite-data/src/guide/parser.ts +++ b/packages/suite-data/src/guide/parser.ts @@ -75,7 +75,7 @@ export class Parser { .match(/^# (.+$)/m)![1]! .replace(/[\\]/g, '') .trim(); - } catch (e) { + } catch { throw new Error(`Could not parse title from ${path}.`); } } diff --git a/packages/suite-data/src/translations/list-unused.ts b/packages/suite-data/src/translations/list-unused.ts index 6488ea8df10..f3fb6f7e3d3 100644 --- a/packages/suite-data/src/translations/list-unused.ts +++ b/packages/suite-data/src/translations/list-unused.ts @@ -9,6 +9,7 @@ import messages from '@trezor/suite/src/support/messages'; console.log('unused messages: '); const rootDir = path.join(__dirname, '..', '..', '..', '..'); + function execLocal(cmd: string) { return execSync(cmd, { encoding: 'utf-8', @@ -60,7 +61,7 @@ for (const message in messages) { try { execLocal(cmd); - } catch (err) { + } catch { unused.push(message); } } diff --git a/packages/suite-web/e2e/stubs/metadata.ts b/packages/suite-web/e2e/stubs/metadata.ts index 35210ab18eb..4824b6d0e23 100644 --- a/packages/suite-web/e2e/stubs/metadata.ts +++ b/packages/suite-web/e2e/stubs/metadata.ts @@ -16,7 +16,7 @@ export const rerouteMetadataToMockProvider = ( let url; try { url = new URL(uri); - } catch (_err) { + } catch { // catching absolute next.js urls which throw in URL constructor return fetch(uri, options); } diff --git a/packages/suite/src/actions/suite/modalActions.ts b/packages/suite/src/actions/suite/modalActions.ts index 7087202f975..61c74cf77ed 100644 --- a/packages/suite/src/actions/suite/modalActions.ts +++ b/packages/suite/src/actions/suite/modalActions.ts @@ -84,7 +84,7 @@ export const openDeferredModal = }); try { return dfd.promise; - } catch (error) { + } catch { // do nothing, return void } }; diff --git a/packages/suite/src/actions/wallet/cardanoStakingActions.ts b/packages/suite/src/actions/wallet/cardanoStakingActions.ts index 21dbd812d01..2eb4b13990d 100644 --- a/packages/suite/src/actions/wallet/cardanoStakingActions.ts +++ b/packages/suite/src/actions/wallet/cardanoStakingActions.ts @@ -132,7 +132,7 @@ export const fetchTrezorPools = (network: 'ADA' | 'tADA') => async (dispatch: Di trezorPools: responseJson as PoolsResponse, network: cardanoNetwork, }); - } catch (err) { + } catch { dispatch({ type: CARDANO_STAKING.SET_FETCH_ERROR, error: true, diff --git a/packages/suite/src/actions/wallet/coinjoinAccountActions.ts b/packages/suite/src/actions/wallet/coinjoinAccountActions.ts index cfd47ea4ef4..e1c9471e807 100644 --- a/packages/suite/src/actions/wallet/coinjoinAccountActions.ts +++ b/packages/suite/src/actions/wallet/coinjoinAccountActions.ts @@ -120,6 +120,7 @@ const coinjoinAccountAuthorizeFailed = (accountKey: string, error: string) => }, }) as const; +// eslint-disable-next-line @typescript-eslint/no-unused-vars const coinjoinAccountUnregister = (accountKey: string) => ({ type: COINJOIN.ACCOUNT_UNREGISTER, diff --git a/packages/suite/src/components/suite/DeviceDisplay/__tests__/DeviceDisplay.test.tsx b/packages/suite/src/components/suite/DeviceDisplay/__tests__/DeviceDisplay.test.tsx index 3c3563211f2..c5bd163a430 100644 --- a/packages/suite/src/components/suite/DeviceDisplay/__tests__/DeviceDisplay.test.tsx +++ b/packages/suite/src/components/suite/DeviceDisplay/__tests__/DeviceDisplay.test.tsx @@ -9,10 +9,10 @@ import { renderWithProviders } from '../../../../support/tests/hooksHelper'; import { extraDependencies } from '../../../../support/extraDependencies'; import suiteReducer from '../../../../reducers/suite/suiteReducer'; -const deviceReducer = prepareDeviceReducer(extraDependencies); +const _deviceReducer = prepareDeviceReducer(extraDependencies); type State = { - device: DeepPartial>; + device: DeepPartial>; suite: DeepPartial>; }; diff --git a/packages/suite/src/hooks/suite/useLocales.ts b/packages/suite/src/hooks/suite/useLocales.ts index 087c46e35f8..0a1bc3c4b50 100644 --- a/packages/suite/src/hooks/suite/useLocales.ts +++ b/packages/suite/src/hooks/suite/useLocales.ts @@ -17,7 +17,7 @@ export const useLocales = () => { let dateLocale; try { dateLocale = await import(`date-fns/locale/${lang}/index`); - } catch (error) { + } catch { dateLocale = await import(`date-fns/locale/en-US/index`); console.warn( diff --git a/packages/suite/src/services/google.ts b/packages/suite/src/services/google.ts index c4f25a15c2d..14080733065 100644 --- a/packages/suite/src/services/google.ts +++ b/packages/suite/src/services/google.ts @@ -172,7 +172,7 @@ class Client { static async isAuthServerAvailable() { try { Client.authServerAvailable = (await fetch(`${Client.authServerUrl}/status`)).ok; - } catch (err) { + } catch { Client.authServerAvailable = false; } diff --git a/packages/suite/src/services/suite/metadata/DropboxProvider.ts b/packages/suite/src/services/suite/metadata/DropboxProvider.ts index 27b00b52aa3..288199b88b7 100644 --- a/packages/suite/src/services/suite/metadata/DropboxProvider.ts +++ b/packages/suite/src/services/suite/metadata/DropboxProvider.ts @@ -49,7 +49,7 @@ class DropboxProvider extends AbstractMetadataProvider { await this.auth.refreshAccessToken(['']); return true; - } catch (err) { + } catch { return false; } } @@ -238,6 +238,7 @@ class DropboxProvider extends AbstractMetadataProvider { return this.handleProviderError(err); } } + /** * Specific implementation in every provider. Returns standardized error */ diff --git a/packages/suite/src/services/suite/metadata/GoogleProvider.ts b/packages/suite/src/services/suite/metadata/GoogleProvider.ts index cc676b7aa81..36749fbee71 100644 --- a/packages/suite/src/services/suite/metadata/GoogleProvider.ts +++ b/packages/suite/src/services/suite/metadata/GoogleProvider.ts @@ -4,6 +4,7 @@ import GoogleClient from 'src/services/google'; class GoogleProvider extends AbstractMetadataProvider { connected = false; isCloud = true; + constructor(tokens: Tokens, environment: OAuthServerEnvironment) { super('google'); GoogleClient.init(tokens, environment); @@ -179,7 +180,7 @@ class GoogleProvider extends AbstractMetadataProvider { const result = await GoogleClient.getAccessToken(); return !!result; - } catch (_err) { + } catch { return false; } } diff --git a/packages/suite/src/support/tests/hooksHelper.tsx b/packages/suite/src/support/tests/hooksHelper.tsx index 9653a0df2b5..2be6e0a554f 100644 --- a/packages/suite/src/support/tests/hooksHelper.tsx +++ b/packages/suite/src/support/tests/hooksHelper.tsx @@ -30,7 +30,7 @@ export const waitForLoader = (text = /Loading/i) => { if (loading) { return waitForElementToBeRemoved(() => screen.queryByText(text), { timeout: 5000 }); } - } catch (e) { + } catch { return true; } }; diff --git a/packages/suite/src/utils/suite/parseUri.ts b/packages/suite/src/utils/suite/parseUri.ts index bc2ab9846e5..eb832b7dd35 100644 --- a/packages/suite/src/utils/suite/parseUri.ts +++ b/packages/suite/src/utils/suite/parseUri.ts @@ -6,7 +6,7 @@ export const parseQuery = (uri: string) => { new URLSearchParams(uri.substring(index)).forEach((v, k) => { params[k] = v; }); - } catch (e) { + } catch { // empty } @@ -16,7 +16,7 @@ export const parseQuery = (uri: string) => { export const parseUri = (uri: string) => { try { return new URL(uri); - } catch (e) { + } catch { // empty } }; diff --git a/packages/suite/src/utils/suite/passwords.ts b/packages/suite/src/utils/suite/passwords.ts index f162e606886..f3b6d33f2a2 100644 --- a/packages/suite/src/utils/suite/passwords.ts +++ b/packages/suite/src/utils/suite/passwords.ts @@ -1,7 +1,7 @@ export const getDisplayKey = (title: string, username: string) => { try { return `Unlock ${new URL(title).host} for user ${username}?`; - } catch (err) { + } catch { return `Unlock ${title} for user ${username}?`; } }; diff --git a/packages/suite/src/utils/wallet/coinmarket/coinmarketUtils.ts b/packages/suite/src/utils/wallet/coinmarket/coinmarketUtils.ts index 2b43ea07adc..342a6960d16 100644 --- a/packages/suite/src/utils/wallet/coinmarket/coinmarketUtils.ts +++ b/packages/suite/src/utils/wallet/coinmarket/coinmarketUtils.ts @@ -150,7 +150,7 @@ export const getCountryLabelParts = (label: string) => { const text = parts.join(' '); return { flag, text }; - } catch (err) { + } catch { return null; } }; diff --git a/packages/suite/src/views/wallet/transactions/TransactionList/TransactionListActions/TransactionListActions.tsx b/packages/suite/src/views/wallet/transactions/TransactionList/TransactionListActions/TransactionListActions.tsx index edd9a1fd7b6..e5e762f6100 100644 --- a/packages/suite/src/views/wallet/transactions/TransactionList/TransactionListActions/TransactionListActions.tsx +++ b/packages/suite/src/views/wallet/transactions/TransactionList/TransactionListActions/TransactionListActions.tsx @@ -60,7 +60,7 @@ export const TransactionListActions = ({ noLoading: true, }), ); - } catch (err) { + } catch { dispatch( notificationsActions.addToast({ type: 'error', diff --git a/packages/transport/src/api/udp.ts b/packages/transport/src/api/udp.ts index 62a223a740f..a95a9421d73 100644 --- a/packages/transport/src/api/udp.ts +++ b/packages/transport/src/api/udp.ts @@ -181,7 +181,7 @@ export class UdpApi extends AbstractApi { this.handleDevicesChange(enumerateResult); return this.success(enumerateResult); - } catch (e) { + } catch { this.handleDevicesChange([]); return this.error({ error: ERRORS.ABORTED_BY_SIGNAL }); diff --git a/packages/transport/src/utils/bridgeApiCall.ts b/packages/transport/src/utils/bridgeApiCall.ts index 274ecbd267d..50ae541b901 100644 --- a/packages/transport/src/utils/bridgeApiCall.ts +++ b/packages/transport/src/utils/bridgeApiCall.ts @@ -38,7 +38,7 @@ function wrapBody(body: unknown) { function parseResult(text: string): Record | string { try { return JSON.parse(text); - } catch (e) { + } catch { return text; } } diff --git a/packages/transport/src/utils/bridgeApiResult.ts b/packages/transport/src/utils/bridgeApiResult.ts index 2059678eb3d..2c03c767d5f 100644 --- a/packages/transport/src/utils/bridgeApiResult.ts +++ b/packages/transport/src/utils/bridgeApiResult.ts @@ -83,7 +83,7 @@ export function acquire(res: UnknownPayload) { export function call(res: UnknownPayload) { try { return success(validateProtocolMessage(res, true)); - } catch (e) { + } catch { return error({ error: ERRORS.WRONG_RESULT_TYPE }); } } @@ -91,7 +91,7 @@ export function call(res: UnknownPayload) { export function post(res: UnknownPayload) { try { return success(validateProtocolMessage(res, false)); - } catch (e) { + } catch { return error({ error: ERRORS.WRONG_RESULT_TYPE }); } } diff --git a/packages/utxo-lib/src/address.ts b/packages/utxo-lib/src/address.ts index b5f75de0537..9721feb4a0a 100644 --- a/packages/utxo-lib/src/address.ts +++ b/packages/utxo-lib/src/address.ts @@ -29,7 +29,7 @@ export function fromBech32(address: string): Bech32Result { let version: number; try { result = bech32.decode(address); - } catch (e) { + } catch { // silent } @@ -83,32 +83,32 @@ function toFutureSegwitAddress(output: Buffer, network = BITCOIN_NETWORK) { export function fromOutputScript(output: Buffer, network = BITCOIN_NETWORK) { try { return payments.p2pkh({ output, network }).address as string; - } catch (e) { + } catch { // empty } try { return payments.p2sh({ output, network }).address as string; - } catch (e) { + } catch { // empty } try { return payments.p2wpkh({ output, network }).address as string; - } catch (e) { + } catch { // empty } try { return payments.p2wsh({ output, network }).address as string; - } catch (e) { + } catch { // empty } try { return payments.p2tr({ output, network }).address as string; - } catch (e) { + } catch { // empty } try { return toFutureSegwitAddress(output, network); - } catch (e) { + } catch { // empty } diff --git a/packages/utxo-lib/src/bufferutils.ts b/packages/utxo-lib/src/bufferutils.ts index 4a62fd72dba..f78e75ad743 100644 --- a/packages/utxo-lib/src/bufferutils.ts +++ b/packages/utxo-lib/src/bufferutils.ts @@ -38,7 +38,7 @@ export function readUInt64LEasString(buffer: Buffer, offset: number) { const result = readUInt64LE(buffer, offset); return result.toString(); - } catch (error) { + } catch { const aUint = buffer.readUInt32LE(offset); const bUint = buffer.readUInt32LE(offset + 4); const m = new BN(0x100000000); diff --git a/packages/utxo-lib/src/coinselect/coinselectUtils.ts b/packages/utxo-lib/src/coinselect/coinselectUtils.ts index b9cc459cb5f..635c1e565c0 100644 --- a/packages/utxo-lib/src/coinselect/coinselectUtils.ts +++ b/packages/utxo-lib/src/coinselect/coinselectUtils.ts @@ -144,7 +144,7 @@ export function bignumberOrNaN(v?: BN | string, forgiving = false) { try { return new BN(v); - } catch (error) { + } catch { return defaultValue; } } diff --git a/packages/utxo-lib/src/crypto.ts b/packages/utxo-lib/src/crypto.ts index 4e4e3881db3..d0ba734b6b8 100644 --- a/packages/utxo-lib/src/crypto.ts +++ b/packages/utxo-lib/src/crypto.ts @@ -9,7 +9,7 @@ import { createHash } from 'crypto'; export function ripemd160(buffer: Buffer): Buffer { try { return createHash('rmd160').update(buffer).digest(); - } catch (err) { + } catch { return createHash('ripemd160').update(buffer).digest(); } } diff --git a/packages/utxo-lib/src/networks.ts b/packages/utxo-lib/src/networks.ts index 91a1d6394f2..a8869ae4b36 100644 --- a/packages/utxo-lib/src/networks.ts +++ b/packages/utxo-lib/src/networks.ts @@ -278,7 +278,7 @@ export function isNetworkType(type: NetworkTypes, network?: Network) { }, network, ); - } catch (e) { + } catch { return false; }