Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Trade: Enable network via trade account select #16990

Closed
vytick opened this issue Feb 13, 2025 · 2 comments · Fixed by #17266
Closed

Mobile Trade: Enable network via trade account select #16990

vytick opened this issue Feb 13, 2025 · 2 comments · Fixed by #17266
Assignees
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@vytick
Copy link
Contributor

vytick commented Feb 13, 2025

Enable network and discover accounts via trade when selecting account of not enabled networks.

The UI is already done in module-add-account flow (AddCoinDiscoveryRunningScreen and AddCoinDiscoveryFinishedScreen). We need to extract the functionality and make it reusable in from a new package.

Figma design

Image
@vytick vytick added the mobile Suite Lite issues and PRs label Feb 13, 2025
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Feb 13, 2025
@vytick vytick self-assigned this Feb 14, 2025
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Feb 26, 2025
@vytick vytick moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Mobile Mar 7, 2025
@vytick
Copy link
Contributor Author

vytick commented Mar 7, 2025

@trezor/qa:

Since this contains some minor changes to add account flow, please, retest that adding a new account works in all use cases as before:

  1. When user has discovered coin, he can add a new account
  2. If there are multiple types allowed, he can only add a new account of a type (e.g. another BTC segwit account) if there is no empty account of this network and a type.
  3. If network is not discovered, during this flow it should discover all used accounts and also allow user to add a new account of each type (given that rules in 2. allow it)
  4. In Trade section, when user picks asset to be bought (e.g. BTC) he can also add new account (rules in 2. apply)
  5. If the network of selected asset in 4. was not enabled before, user can add new account and it will enable the network and discover all accounts. User can then pick one of those or add a new on (as described in 4.)
  6. When device is not connected or the device is Portfolio account, adding new account should not work

@STew790
Copy link
Contributor

STew790 commented Mar 10, 2025

QA OK

  1. OK
  2. OK
  3. OK (rules from 2. applies)
  4. OK (Rules from 2. applies)
  5. OK (accounts from network are discovered and user can pick the same as in 4.)
  6. OK (cant add new account, do we really need the trad tab in portfolio btw? 🤔 )

Info
25.3.1 ad860bf

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Mar 10, 2025
@STew790 STew790 added QA Quality assurance related QA OK Issue passed QA without any blocker and removed QA Quality assurance related labels Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

2 participants