Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address label not showing in the coin control section #16069

Closed
WURMiL opened this issue Dec 19, 2024 · 2 comments · Fixed by #16882
Closed

Address label not showing in the coin control section #16069

WURMiL opened this issue Dec 19, 2024 · 2 comments · Fixed by #16882
Assignees
Labels
bug Something isn't working as expected coin control

Comments

@WURMiL
Copy link

WURMiL commented Dec 19, 2024

Describe the bug
In the "Receive" section I can add label to specific addresses. But is the coin control section these labels are not shown. I can see only addresses and labels belonging to specific UTXO

Info:

  • Suite Version: app 24.11.3
  • OS: Windows 10

How to reproduce
Steps to reproduce the behavior:

  1. Select Bitcoin
  2. Click on 'Receive'
  3. Add label to any used address
  4. Go back
  5. Click on 'Send'
  6. Activate Coin control
  7. Label is not displayed. Only the address

Expected behavior
Instead or better next to the address the label should be displayed

@WURMiL WURMiL added the bug Something isn't working as expected label Dec 19, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Dec 19, 2024
@WURMiL WURMiL changed the title Address label is not show in the coin control section Address label not showing in the coin control section Dec 22, 2024
@komret
Copy link
Contributor

komret commented Jan 10, 2025

TODO

If an address has label, show label instead (as in the receive section).

Rationale:

In that case, the address won't be displayed. I was thinking of adding a tooltip, but it would be cluttered. I don't think there is a real use case for displaying the address at this point, it can be checked in transaction details if needed.

@komret komret self-assigned this Feb 6, 2025
@komret komret mentioned this issue Feb 6, 2025
@komret komret moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Desktop Feb 26, 2025
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Suite Desktop Mar 3, 2025
@bosomt bosomt moved this from 🤝 Needs QA to 🧪 QA In progress in Suite Desktop Mar 4, 2025
@bosomt
Copy link
Contributor

bosomt commented Mar 4, 2025

QA OK

  • addresses labels are present
  • im not able to change address labels in coin control section
  • im able to change/add labels to UTXOs in coin control section
  • works as expected
Image Image Image

Info:

  • Suite version: desktop 25.3.0 (2a761d4)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.3.0 Chrome/132.0.6834.194 Electron/34.1.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1470x956
  • Device: Trezor T2B1 2.8.9 regular (revision fad9682201cf9289bba2adb66e6e07ed1cf78936)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🧪 QA In progress to ✅ Approved in Suite Desktop Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected coin control
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

3 participants