Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Do not) Reintroduce @typescript-eslint/no-shadow #15311

Closed
Tracked by #15196
peter-sanderson opened this issue Nov 7, 2024 · 1 comment
Closed
Tracked by #15196

(Do not) Reintroduce @typescript-eslint/no-shadow #15311

peter-sanderson opened this issue Nov 7, 2024 · 1 comment

Comments

@peter-sanderson
Copy link
Contributor

peter-sanderson commented Nov 7, 2024

I think it brings more hard then benefit. It supper annoying and I am not sure if it really can help with something.

With Typescript, its very hard to introduce an error by shadowing anyway,

Even with most lenient configuration

'@typescript-eslint/no-shadow': [
    'error',
    {
        builtinGlobals: false,
        hoist: 'never', // most lenient variant
        allow: ['_', 'error', 'resolve', 'reject', 'fetch'],
    },
],

It is 192 errors

@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Nov 7, 2024
@peter-sanderson peter-sanderson self-assigned this Nov 7, 2024
@peter-sanderson peter-sanderson changed the title Reintroduce no-shadow which I have removed due to hard configuration and many weird errors. Maybe I am just dumb. (Do not) Reintroduce no-shadow Nov 8, 2024
@peter-sanderson peter-sanderson changed the title (Do not) Reintroduce no-shadow (Do not) Reintroduce @typescript-eslint/no-shadow Nov 8, 2024
@Nodonisko
Copy link
Contributor

Nodonisko commented Nov 8, 2024

We agreed to turn this on not that long ago and I prefer to have this enabled.

You may disable this for this desktop if you want but please leave this on for mobile.

@peter-sanderson peter-sanderson removed their assignment Nov 11, 2024
@peter-sanderson peter-sanderson self-assigned this Nov 13, 2024
@github-project-automation github-project-automation bot moved this from 🎯 To do to 🤝 Needs QA in Suite Desktop Nov 13, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Desktop Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants