Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order networks by networkConfig #15222

Closed
vytick opened this issue Nov 5, 2024 · 1 comment · Fixed by #15282
Closed

Order networks by networkConfig #15222

vytick opened this issue Nov 5, 2024 · 1 comment · Fixed by #15282
Assignees
@vytick
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Milestone
Mobile - Polygon ...

Comments

@vytick
Copy link
Contributor

vytick commented Nov 5, 2024 •
edited
Loading

Currently mobile app uses custom ordering of networks in coin enabling, dashboard and portfolio tracker . Remove this and use ordering based on how networks are ordered in the networksConfig.
@vytick vytick added the mobile Suite Lite issues and PRs label Nov 5, 2024
@vytick vytick added this to the Mobile - Polygon & BNB milestone Nov 5, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Mobile Nov 5, 2024
@vytick vytick changed the title Polygon - order networks by networkConfig Order networks by networkConfig Nov 5, 2024
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Nov 5, 2024
@vytick vytick removed the status in Suite Mobile Nov 5, 2024
@vytick vytick moved this to 🎯 To do in Suite Mobile Nov 5, 2024
@vytick vytick self-assigned this Nov 6, 2024
@vytick vytick moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Nov 6, 2024
@vytick vytick mentioned this issue Nov 6, 2024
Merged
@vytick vytick moved this from 🏃‍♀️ In progress to ✅ Approved in Suite Mobile Nov 11, 2024
@vytick vytick moved this from ✅ Approved to 🤝 Needs QA in Suite Mobile Nov 11, 2024
@STew790
Copy link
Contributor

STew790 commented Nov 11, 2024

QA OK
Networks are ordered correctly according to https://github.com/trezor/trezor-suite/blob/develop/suite-common/wallet-config/src/networksConfig.ts

Info
24.11.1 ff16b78

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Nov 11, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
Mobile - Polygon & BNB
Development

Successfully merging a pull request may close this issue.

feat(suite-native): sort networks according to networksConfig trezor/trezor-suite
2 participants
@vytick @STew790