chore: enable no-constant-binary-expression as it becames recommanded default in new ESLint

Author: peter-sanderson

.eslintrc.js

@@ -61,6 +61,7 @@ module.exports = {
     rules: {
         'no-extra-boolean-cast': 'error',
         'no-irregular-whitespace': 'error',
+        'no-constant-binary-expression': 'error',
         'no-empty': 'error',
         '@typescript-eslint/no-empty-object-type': 'off',
         '@typescript-eslint/no-require-imports': 'off',

packages/connect-popup/e2e/tests/methods.test.ts

@@ -62,6 +62,7 @@ filteredFixtures.forEach(f => {
         // - fixture require different device than prev fixture, or
         // - fixture is retried
         // FIXME: always reset for now, due to flaky tests with bridge bug
+        // eslint-disable-next-line no-constant-binary-expression
         if (true || JSON.stringify(device) !== JSON.stringify(f.device) || retry) {
             device = f.device;
             await TrezorUserEnvLink.stopBridge();

packages/suite/src/components/wallet/Pagination.tsx

@@ -99,7 +99,7 @@ export const Pagination = ({
                     <PageItem
                         key={i}
                         data-testid={`@wallet/accounts/pagination/${i}`}
-                        data-test-activated={i === currentPage ?? 'true'}
+                        data-test-activated={i === currentPage}
                         onClick={() => onPageSelected(i)}
                         $isActive={i === currentPage}
                     >

packages/suite/src/views/dashboard/PortfolioCard/PortfolioCard.tsx

@@ -77,8 +77,8 @@ export const PortfolioCard = memo(() => {
     }
 
     const isWalletEmpty = !discoveryStatus && isDeviceEmpty;
-    const isWalletLoading = discoveryStatus?.status === 'loading' ?? false;
-    const isWalletError = discoveryStatus?.status === 'exception' ?? false;
+    const isWalletLoading = discoveryStatus?.status === 'loading';
+    const isWalletError = discoveryStatus?.status === 'exception';
     const showGraphControls =
         !isWalletEmpty && !isWalletLoading && !isWalletError && !dashboardGraphHidden;