@uppy/angular does not seem to be picking up changes to [props] attribute for <uppy-dashboard>

[bdirito]

Initial checklist

• I understand this is a bug report and questions should be posted in the Community Forum
• I searched issues and couldn’t find anything (or linked relevant results below)

Link to runnable example

https://stackblitz.com/edit/uppy-demo-ajunvm?file=src%2Fapp.component.ts

Steps to reproduce

On the linked demo the uppy dashboard loads with the the option {disabled: true}. If you click the button labeled 'Update the props object passed to uppy-dashboard' angular will update the object being passed to the '[props]' attribute of <uppy-dashboard> This can be seen by 'Props are' text being updated.

Expected behavior

I would expect updates to the [props] attribute of <uppy-dashboard> to be picked up; and for the new value of {disabled: false} to enable interactivity.

Actual behavior

The dashboard remains disabled.

As a workaround I've found that you can set the options directly as via an uppy.setOptions(); call. Passing in what are fundamentally dashboard options to the uppy object itself is very much Illegal according to the documented apis & types. But it does seem to work. This behavior can be seen by first pressing the 'Update the props object passed to uppy-dashboard' button to update the properties and then pressing the 'Directly apply the props via object call' to preform the workaround.

[aduh95]

I would expect updates to the [props] attribute of <uppy-dashboard> to be picked up; and for the new value of {disabled: false} to enable interactivity.

Interestingly, the value is picked up, you can see if you replace the uppy.setOptions with

uppy.getPlugin('angular:Dashboard')!.setOptions(this.uppyOptions());

then the second button doesn't have any more effect than changing the props. However, if we change it to

(uppy.getPlugin('angular:Dashboard') as any).setPluginState({})

Then it works the same as calling uppy.setOptions(). The bug seems to be that Dashboard (and maybe other UI components are also affected) does not re-render when setOptions is called. On the Uppy class, some custom logic was added to take this behavior into account, maybe we should do the same on Dashboard/UIPlugin:

uppy/packages/@uppy/core/src/Uppy.ts

Lines 604 to 605 in 09e6a0f

	// Note: this is not the preact `setState`, it's an internal function that has the same name.
	this.setState(undefined) // so that UI re-renders with new options

//cc @Murderlon