Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory not empty #91

Open
breuerfelix opened this issue Aug 19, 2020 · 6 comments
Open

Directory not empty #91

breuerfelix opened this issue Aug 19, 2020 · 6 comments

Comments

@breuerfelix
Copy link

image

i would love to use this tool, somehow this happens with 2 simple mp4 videos.
i am on arch-linux and i used npm install ffmpeg-concat to install it.
also the videos doesnt seem to be the problem here.

@breuerfelix
Copy link
Author

when specifying a temp folder with -O it works until this happens

image

the problem is that it deletes the temp folder i pass in, so i cannot check if the files were present or not

@breuerfelix
Copy link
Author

it works when specifying an absolute path as a temp directory.

so now i got it working but the default temp folder does NOT work and non-absolute paths only work 50% :) maybe someone could look into this

@breuerfelix
Copy link
Author

Even though i supply a temp directory via cli, i still get the error directory not empty...

@transitive-bullshit
Copy link
Owner

Hmmm, we're doing a rm -rf of the temp directory after using all of the individual frames. I'm not sure why you'd be getting this error, though.

It looks like this may be a Windows issue. What's the specific environment you're running in?

@breuerfelix
Copy link
Author

Hmmm, we're doing a rm -rf of the temp directory after using all of the individual frames. I'm not sure why you'd be getting this error, though.

It looks like this may be a Windows issue. What's the specific environment you're running in?

ye i saw that in the sources... you use this temp dir library which should handle all of that.
it is really weird that this error occurs from time to time and i dont really know when it happens. but maybe you could add the ability to specify a temp dir as a relative path :)

i am using arch linux, so rm -rf should be fine. also i think its not a permission problem since than i would get another error.

@bjollans
Copy link

I was running into the same issue and figured out why this happens. If you are trying to concatenate a lot of video files, the temp directory can get very big. In my case it reached ~900GB. I am not sure how ffmpeg-concat runs into issues when deleting the directory, but this has consistently happened on my machine for extremely large directories. I had this issue even when using a custom directory with the -O option.

The solution for me was to also add -C to not cleanup the frames automatically. Then you can also inspect the temp files after your run and see if they are using too much space. If you are running into space problems, I was able to reduce the disk usage ~4x by changing the frame format to PNG (-f png). But this makes the code a lot slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants