From b53831a255a5017d5b6a70bf3e50a5e26cbe326b Mon Sep 17 00:00:00 2001 From: toyobayashi Date: Sat, 9 Mar 2024 14:37:43 +0800 Subject: [PATCH] test: move NAPI_EXPERIMENTAL definition to cmake file (nodejs/node#51254) --- packages/test/CMakeLists.txt | 2 ++ packages/test/string/binding.c | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/test/CMakeLists.txt b/packages/test/CMakeLists.txt index 0c900593..1f55be23 100644 --- a/packages/test/CMakeLists.txt +++ b/packages/test/CMakeLists.txt @@ -253,6 +253,7 @@ add_test("tsfn2_st" "./tsfn2/binding.c" OFF) if((NOT IS_WASM) OR IS_EMSCRIPTEN OR IS_WASI_THREADS) add_test("string_mt" "./string/binding.c;./string/test_null.c" ON) + target_compile_definitions("string_mt" PRIVATE "NAPI_EXPERIMENTAL") add_test("pool" "./pool/binding.c" ON) add_test("tsfn" "./tsfn/binding.c" ON) add_test("async_cleanup_hook" "./async_cleanup_hook/binding.c" ON) @@ -267,6 +268,7 @@ add_test("fnfac" "./fnfac/binding.c" OFF) add_test("general" "./general/binding.c" OFF) add_test("filename" "./filename/binding.c" OFF) add_test("string" "./string/binding.c;./string/test_null.c" OFF) +target_compile_definitions("string" PRIVATE "NAPI_EXPERIMENTAL") add_test("property" "./property/binding.c" OFF) add_test("promise" "./promise/binding.c" OFF) add_test("object" "./object/test_null.c;./object/test_object.c" OFF) diff --git a/packages/test/string/binding.c b/packages/test/string/binding.c index 31425e2a..95108c98 100644 --- a/packages/test/string/binding.c +++ b/packages/test/string/binding.c @@ -1,3 +1,4 @@ +#include #include // INT_MAX #if !defined(__wasm__) || (defined(__EMSCRIPTEN__) || defined(__wasi__)) @@ -25,8 +26,6 @@ size_t strlen(const char *s) } #endif -#define NAPI_EXPERIMENTAL -#include #include "../common.h" #include "../entry_point.h" #include "test_null.h"