Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installing readme-renderer[md] should not be necessary #1116

Closed
todo bot opened this issue Jan 2, 2019 · 2 comments
Closed

installing readme-renderer[md] should not be necessary #1116

todo bot opened this issue Jan 2, 2019 · 2 comments
Assignees
@obestwalter
Labels
todo 🗒️

Comments

@todo
Copy link

todo bot commented Jan 2, 2019

tox/tox.ini

Lines 44 to 48 in 7f88569

# TODO installing readme-renderer[md] should not be necessary
readme-renderer[md] >= 24.0
pip >= 18.0.0
skip_install = true
extras =

This issue was generated by todo based on a TODO comment in 7f88569 when #1114 was merged. cc @tox-dev.
@todo todo bot added the todo 🗒️ label Jan 2, 2019
@obestwalter obestwalter self-assigned this Jan 2, 2019
@obestwalter obestwalter reopened this Jan 2, 2019
@obestwalter
Copy link
Member

obestwalter commented Jan 2, 2019 •
edited
Loading

Tracking this here:

I asked about it on the list. If there is consensus about making markdown support the default it could be "fixed" in readme-renderer diretly by adding the dependency to the normal install_requires deps and everything else can go away.

https://groups.google.com/forum/#!topic/pypa-dev/BevObZsKVOQ

@obestwalter obestwalter mentioned this issue Jan 9, 2019
Closed
@gaborbernat
Copy link
Member

Fixed now I believe.

@tox-dev tox-dev locked and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obestwalter obestwalter

Labels
todo 🗒️
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obestwalter @gaborbernat