Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen playback is broken #10

Open
prabhu opened this issue Aug 19, 2016 · 4 comments
Open

Fullscreen playback is broken #10

prabhu opened this issue Aug 19, 2016 · 4 comments

Comments

@prabhu
Copy link

prabhu commented Aug 19, 2016

Its not resizing to full screen :(

@prabhu
Copy link
Author

prabhu commented Aug 24, 2016

I have wasted too much time on this? Are you planning to take a look?

@tobilen
Copy link

tobilen commented Nov 4, 2016

#11

@onigetoc
Copy link

Same here, fullscreen broken

@ewwink
Copy link

ewwink commented May 10, 2017

I don't think we need resize event because we only need to set size of parent iframe div to 100% to follow player size, here what i'm talking:

<div player-wrapper>
    <div data-player="" style="height: 360px; width: 640px;"> // player size
         <div class="clappr-youtube-playback"> // resize here to 100% to follow size above
            <iframe src"..youtube.."> // youtube already set size to 100%

and for quick fix, replace:

this.player = new YT.Player('yt' + this.cid, {
    videoId: this.options.src,
    playerVars: playerVars,
    events: {

with:

this.player = new YT.Player('yt' + this.cid, {
    videoId: this.options.src,
    playerVars: playerVars,
    width: '100%', 
    height: '100%',
    events: {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants