-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer working since Today #30
Comments
Thanks, I see it too. Error from
Not sure what changed or how to fix it. |
@tomhollander thanks for validating. |
As per https://tesla-api.timdorr.com/api-basics/authentication, Also unfortunately this isn't just impacting 2FA users - seems to be broken for everyone. |
Yes, for my app it is also broken :( |
Seems to work again here: https://tesla-info.com/tesla-token.php |
@Urkman Yeah, that seems to work again but TeslaAuth isn't showing the values. I don't have time ATM to analyze this. |
There's some discussion on this at timdorr/tesla-api#689. If/when we figure out the solution I'll try to get an updated library ASAP (PRs welcome if anyone beats me to it). |
I don't have a solution, but I have some things that didn't work with the TeslaAuthHelper class. I'm going to post this here because it was specific attempts at improving this code base, and also didn't solve the problem.
|
This is how I fixed it for my implementation.
The change for me was getting the |
Sounds like we have some leads now. I won't have time to look at this for the next 12 hours, but if anyone can raise a PR I can merge and publish to NuGet. Or I can try to fix tonight. |
Thanks @mavese I got a fix. Your hint about the digest vs. hexdigest commands sent me on a weird tangent on investigating Python's crypto library, but in the end I realized some of our problems could be coming from a sloppy comingling of bytes & chars, with extra conversions potentially in a way that depends on machine state. I threw out what we were doing and rewrote it to avoid the excess conversions, and it solved the problem. We did also have to add in the URL safe encoding handling for a few special characters. The [:-1] trick you are using seems like an incomplete workaround because you'll miss other characters. Check this out.
Then the Base64UrlEncode method:
Note: You might want to look at what encode does, and whether it should be done before or after hashing. |
Thanks so much @brianflex! PR merged, and now published to Nuget as v2.3.0. |
Yesterday the tesla API was raising 500 / 503 errors. Today things seem running healthy except that since then the works demo isn't showing the values anymore after logging in.
Other methods like https://tesla-info.com/tesla-token.php also are no longer working.
I'm using 2FA
The text was updated successfully, but these errors were encountered: