Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NgPlural in Todos component #362

Closed
tomastrajan opened this issue Oct 1, 2018 · 0 comments
Closed

Use NgPlural in Todos component #362

tomastrajan opened this issue Oct 1, 2018 · 0 comments
Labels
good first issue 🥇 hacktoberfest 🍻 Hacktoberfest is a month-long celebration of open source software help wanted 👋

Comments

@tomastrajan
Copy link
Owner

Describe the feature you'd like:

We should use ngPlural for description of todos filter based on amount of items

Other information:

Please check NgPlural documentation.

We will be replacing

<mat-chip [disabled]=true>
            {{ 'anms.examples.todos.filter.description' | translate }} {{todos.filter !==
            'ALL' ? filteredTodos.length : ''}}
            {{ ('anms.examples.todos.filter.' + todos.filter.toLowerCase() |
            translate).toLowerCase() }}
            {{todos.filter === 'ALL' ? filteredTodos.length : ''}}
            {{ 'anms.examples.todos.filter.items' | translate }}
</mat-chip>

part of todos-container.component.html.

Please use translate for all ngPlural cases, we should be aiming for =0, =1 and >1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue 🥇 hacktoberfest 🍻 Hacktoberfest is a month-long celebration of open source software help wanted 👋
Projects
None yet
Development

No branches or pull requests

1 participant