Handle spurious wakeups #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2023 19:52
that handles spurious wakeups.
hds
approved these changes
Jan 18, 2024
Co-authored-by: Hayden Stainsby <hds@caffeineconcepts.com>
hawkw
approved these changes
Jan 18, 2024
| } | ||
|
|
||
| fn poll(&mut self, cx: &mut Context<'_>) { | ||
| // Spurious wake-ups are allowed, even after a future has |
There was a problem hiding this comment.
it might be worth linking to wherever in the std::future documentation it explains that the future trait contract allows spurious wakeups?
There was a problem hiding this comment.
I'm not actually sure where that's documented, and didn't find anything with a quick search of the obvious candidates. It may be implied by other documentation, or just "common knowledge".
I only became aware of it because @Darksonn commented such on a previous PR.
There was a problem hiding this comment.
@hawkw any thoughts on the above 👆? Otherwise this is good to go 🚀
Darksonn
approved these changes
Feb 28, 2024
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the tutorial to handle spurious wakeups. Continuation from discussion in #739
Playground