Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example/echo.rs doesn't work concurrently #1097

Closed
giraffate opened this issue Nov 11, 2020 · 1 comment · Fixed by #1107
Closed

example/echo.rs doesn't work concurrently #1097

giraffate opened this issue Nov 11, 2020 · 1 comment · Fixed by #1107

Comments

@giraffate
Copy link

Bug Report

https://github.com/tokio-rs/tracing/blob/a8cc977e01ec4e1dce4137e37cfc1bfba7ebbed8/examples/examples/echo.rs doesn't work concurrently. It seems that the commit a8cc977 changed the behavior.
@davidbarsky
Copy link
Member

I'm able to reproduce this issue with two instances of netcat. It seems like adding this .await? caused the echo example to no longer be concurrent.

@davidbarsky davidbarsky mentioned this issue Nov 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples: Fix echo by Reintroducing Concurrency tokio-rs/tracing
2 participants
@davidbarsky @giraffate